Refresh SOCKs logic, remove IpMapConf #9523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh the SOCKs configuration parsing logic using libswoc.
The refresh is actually a side effect. The primary purpose of this PR is to remove
IpMapConfbecause it is a consumer ofIpMapand therefore part of the larger project of removingIpMap. The SOCKs configuration was the only consumer ofIpMapConfso the refresh made it easy to removeIpMapConffrom SOCKs and therefore the entire codebase.I had to make a tweak to libswoc for this PR (see #9522) so that ranges with internal spaces would parse.