Fix compile warning on BoringSSL build #9525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| for (int i = 0; i < sk_X509_num(extra_certs); i++) { | ||
| for (int i = 0; i < static_cast<int>(sk_X509_num(extra_certs)); i++) { |
Member
There was a problem hiding this comment.
Why cast, rather than changing int to the correct type? If you wanted to annoying Leif, you could even do
for ( decltype(sk_X509_num(extra_certs) i = 0 ; ...
Member
Author
There was a problem hiding this comment.
https://godbolt.org/z/GPTGacGGc
You like to do things in inconsistent ways?
Member
There was a problem hiding this comment.
No, decltype was added to deal with this kind of situation.
Example on godbolt
SolidWallOfCode
approved these changes
Mar 16, 2023
Member
Author
|
[approve ci freebsd] |
zwoop
pushed a commit
that referenced
this pull request
Mar 16, 2023
(cherry picked from commit 0bd8816)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
* Slight performance improvements before calling APIHooks::clear (apache#9480) (cherry picked from commit c54a2e2) (cherry picked from commit 782fbfd) * Fix compile warning on BoringSSL build (apache#9525) (cherry picked from commit 0bd8816) (cherry picked from commit c31b062) Co-authored-by: Leif Hedstrom <zwoop@apache.org> Co-authored-by: Masakazu Kitajo <maskit@apache.org>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as code below:
trafficserver/tests/tools/plugins/ssl_client_verify_test.cc
Lines 116 to 117 in c54a2e2