tools: H3 tools build script. Add go+boringssl #9606

brbzull0 · 2023-04-13T13:28:52Z

No description provided.

tools/build_h3_tools.sh

bneradt

Looks great to me. Looks very similar to our Dockerfiles for this, which is good:

https://github.com/apache/trafficserver-ci/blob/66399ae992a19be1f34c607635ff17d2015872b0/docker/rockylinux8/Dockerfile#L131-L140

tools/build_h3_tools.sh

bneradt · 2023-04-13T22:26:39Z

A related change:
#9608

bneradt

Looks good generally. Just one observation.

tools/build_h3_tools.sh

bneradt

One other thing comes to mind: we should update the yum install and apt install lines. I think this will need cargo and rust added, right?

brbzull0 · 2023-04-18T15:37:07Z

One other thing comes to mind: we should update the yum install and apt install lines. I think this will need cargo and rust added, right?

yum/apt seems to be an informative print out. I can add cargo and a link to build up rust, but it will only be an informative text.

for reference, cargo and rust are also mentioned here among others that aren't mentioned here which may also be needed.

cmcfarlen · 2023-04-19T20:15:58Z

What is the intent of this? I see it building boringssl but not building anything that uses it. Are you planning on running this script to install deps for building ATS?

I'd prefer this script not automatically install a new version of go in /usr/local. Can it check for an existing go installation beforehand?

cmcfarlen

I'd prefer this script not automatically install a new version of go in /usr/local. Can it check for an existing go installation beforehand?

brbzull0 · 2023-04-20T09:42:38Z

What is the intent of this? I see it building boringssl but not building anything that uses it. Are you planning on running this script to install deps for building ATS?

I'd prefer this script not automatically install a new version of go in /usr/local. Can it check for an existing go installation beforehand?

This is to build the toolchain around H3/QUIC and QUICHE, boringssl is now mandatory to build ATS with quiche.
go is needed to build boringssl and I think the minimal version is 1.20.

brbzull0 · 2023-04-20T09:48:15Z

I'd prefer this script not automatically install a new version of go in /usr/local. Can it check for an existing go installation beforehand?

I don't use go so please let me know if this is an issue, as I do not use go it makes no diff to me where it sits. But happy to adjust it if we all agreed.

Also -> https://github.com/apache/trafficserver/pull/9606/files#r1165525319

cmcfarlen · 2023-04-20T16:35:21Z

For me I'd prefer this script use the installed go if adequate and if this script installs go that it not go in any directory that might end up being in the user's PATH.

boringssl should be done before quiche. quiche should use the boringssl folder to link.

tools/build_h3_tools.sh

brbzull0 · 2023-04-26T16:46:23Z

tools/build_h3_tools.sh

 [ ! -d quiche ] && git clone --recursive https://github.com/cloudflare/quiche.git
 cd quiche
-cargo build -j4 --package quiche --release --features ffi,pkg-config-meta,qlog
+QUICHE_BSSL_PATH=${BASE}/boringssl QUICHE_BSSL_LINK_KIND=dylib cargo build -j4 --package quiche --release --features ffi,pkg-config-meta,qlog


we use the libs from the boringssl we just built.

bneradt

Looks good. Just a few suggestions.

tools/build_h3_tools.sh

bneradt · 2023-04-26T23:26:32Z

I tested this with my suggested changes for updating the CI builds, and the builds worked fine. I'll be updating the images shortly (either tonight or tomorrow).

Thank you for working on this @brbzull0 .

bneradt · 2023-04-27T00:42:51Z

[approve ci autest rocky]

bneradt · 2023-04-27T01:15:14Z

Looks like the connect, polite_hook_wait, h2enable, h2enable_no_accept_threads, and proxy_protocol tests are now failing with the updated tools. I'll look into this shortly.

On the plus side, while the quiche tests are still running and there are failures, at least the active_timeout test passes now:

https://ci.trafficserver.apache.org/view/10.x-master/job/master/job/quiche/34/console

Running Test active_timeout:... Passed

bneradt · 2023-04-27T01:19:28Z

I see...the curl in the updated tools is very new, 7.88. We'll have to update some gold files I believe. I can work on that in a bit.

tools/build_h3_tools.sh

bneradt · 2023-04-27T03:35:33Z

Looks like the connect, polite_hook_wait, h2enable, h2enable_no_accept_threads, and proxy_protocol tests are now failing with the updated tools. I'll look into this shortly.

On the plus side, while the quiche tests are still running and there are failures, at least the active_timeout test passes now:

https://ci.trafficserver.apache.org/view/10.x-master/job/master/job/quiche/34/console
Running Test active_timeout:... Passed

I updated the gold file tests for the new version of curl here:
#9651

bneradt · 2023-04-27T04:31:31Z

[approve ci autest]

brbzull0 · 2023-04-27T10:53:51Z

Looks like the connect, polite_hook_wait, h2enable, h2enable_no_accept_threads, and proxy_protocol tests are now failing with the updated tools. I'll look into this shortly.
On the plus side, while the quiche tests are still running and there are failures, at least the active_timeout test passes now:
https://ci.trafficserver.apache.org/view/10.x-master/job/master/job/quiche/34/console
Running Test active_timeout:... Passed
I updated the gold file tests for the new version of curl here: #9651

great! the other one that was failing should pass once we get #9642 in.

Thanks for helping with this Brian!!

bneradt · 2023-04-27T13:59:46Z

quiche branch autests are passing with these changes integrated into the rockylinux docker image:
https://ci.trafficserver.apache.org/job/master/job/quiche/35/console

Thanks for working on this. It's nice to see that build green.

brbzull0 · 2023-04-27T16:29:46Z

[approve ci autest]

tools/build_h3_tools.sh

bneradt

Looks great to me, @brbzull0 .

brbzull0 added the Tools label Apr 13, 2023

brbzull0 added this to the 10.0.0 milestone Apr 13, 2023

brbzull0 requested a review from bneradt April 13, 2023 13:28

brbzull0 self-assigned this Apr 13, 2023

brbzull0 commented Apr 13, 2023

View reviewed changes

tools/build_h3_tools.sh Outdated Show resolved Hide resolved

bneradt requested changes Apr 13, 2023

View reviewed changes

tools/build_h3_tools.sh Outdated Show resolved Hide resolved

brbzull0 force-pushed the add_boringssl_to_h3_tools_script branch from 7718f66 to 8359562 Compare April 13, 2023 16:12

brbzull0 force-pushed the add_boringssl_to_h3_tools_script branch from 8359562 to ae6bdc8 Compare April 17, 2023 19:34

bneradt requested changes Apr 17, 2023

View reviewed changes

tools/build_h3_tools.sh Outdated Show resolved Hide resolved

bryancall requested review from bryancall and cmcfarlen April 17, 2023 22:30

brbzull0 force-pushed the add_boringssl_to_h3_tools_script branch from ae6bdc8 to ef21134 Compare April 18, 2023 09:54

bneradt requested changes Apr 18, 2023

View reviewed changes

cmcfarlen requested changes Apr 19, 2023

View reviewed changes

brbzull0 added 3 commits April 26, 2023 15:27

tools: H3 tools build script. Add go+boringssl

116fd23

Include cargo/rust notes.

9228cf1

Fix the order of the deps build.

b4c9c7e

boringssl should be done before quiche. quiche should use the boringssl folder to link.

brbzull0 force-pushed the add_boringssl_to_h3_tools_script branch from a8aae90 to b4c9c7e Compare April 26, 2023 16:43

brbzull0 commented Apr 26, 2023

View reviewed changes

tools/build_h3_tools.sh Outdated Show resolved Hide resolved

brbzull0 commented Apr 26, 2023

View reviewed changes

bneradt requested changes Apr 26, 2023

View reviewed changes

tools/build_h3_tools.sh Outdated Show resolved Hide resolved

tools/build_h3_tools.sh Outdated Show resolved Hide resolved

tools/build_h3_tools.sh Show resolved Hide resolved

bneradt requested changes Apr 27, 2023

View reviewed changes

tools/build_h3_tools.sh Outdated Show resolved Hide resolved

Small tweaks

585ef20

brbzull0 added the QUIC label Apr 27, 2023

update openssl version and some other minor tweak

79146c4

bneradt reviewed Apr 27, 2023

View reviewed changes

tools/build_h3_tools.sh Show resolved Hide resolved

bneradt approved these changes Apr 27, 2023

View reviewed changes

cmcfarlen approved these changes Apr 27, 2023

View reviewed changes

bneradt merged commit 1756f9d into apache:master Apr 27, 2023

tools: H3 tools build script. Add go+boringssl #9606

tools: H3 tools build script. Add go+boringssl #9606

Uh oh!

Conversation

brbzull0 commented Apr 13, 2023

Uh oh!

Uh oh!

bneradt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bneradt commented Apr 13, 2023

Uh oh!

bneradt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bneradt left a comment

Choose a reason for hiding this comment

Uh oh!

brbzull0 commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmcfarlen commented Apr 19, 2023

Uh oh!

cmcfarlen left a comment

Choose a reason for hiding this comment

Uh oh!

brbzull0 commented Apr 20, 2023

Uh oh!

brbzull0 commented Apr 20, 2023

Uh oh!

cmcfarlen commented Apr 20, 2023

Uh oh!

Uh oh!

brbzull0 Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

bneradt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bneradt commented Apr 26, 2023

Uh oh!

bneradt commented Apr 27, 2023

Uh oh!

bneradt commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bneradt commented Apr 27, 2023

Uh oh!

Uh oh!

bneradt commented Apr 27, 2023

Uh oh!

bneradt commented Apr 27, 2023

Uh oh!

brbzull0 commented Apr 27, 2023

Uh oh!

bneradt commented Apr 27, 2023

Uh oh!

brbzull0 commented Apr 27, 2023

Uh oh!

Uh oh!

bneradt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brbzull0 commented Apr 18, 2023 •

edited

Loading

bneradt commented Apr 27, 2023 •

edited

Loading