Fix build issue with c++20 and gcc 8.3 #9696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
did clang format
Contributor
|
It looks like your format added too many spaces |
Contributor
|
Yeh, why would this need a big clang-format change ? |
| make_buffer_size_parser() | ||
| { | ||
| return [l = swoc::Lexicon<int>{ | ||
| swoc::Lexicon<int>::with_multi{ |
Member
|
What exactly was changed, except the |
bneradt
requested changes
May 16, 2023
| make_buffer_size_parser() | ||
| { | ||
| return [l = swoc::Lexicon<int>{ | ||
| swoc::Lexicon<int>::with_multi{ |
Contributor
There was a problem hiding this comment.
Does this extra { have a new closing for it? Unless I'm missing it, that would explain the format issues.
Contributor
Author
|
it is fixed with a different PR now in the master branch. Closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did
make clang-formatthat is why the diff is so big.The real fix is line 83. the addition of
swoc::Lexicon<int>::with_multi{