Skip to content

Fix cqpv log field value on H3 connections #9719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 1 commit into from
May 22, 2023
Merged

Fix cqpv log field value on H3 connections #9719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion proxy/http3/Http3Session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ HQSession::remove_transaction(HQTransaction *trans)
const char *
HQSession::get_protocol_string() const
{
return this->_protocol_string;
return "";
}

int
Expand Down Expand Up @@ -201,6 +201,12 @@ Http3Session::decrement_current_active_connections_stat()
// TODO Implement stats
}

const char *
Http3Session::get_protocol_string() const
{
return "http/3";
}

QPACK *
Http3Session::local_qpack()
{
Expand Down
3 changes: 3 additions & 0 deletions proxy/http3/Http3Session.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ class Http3Session : public HQSession
void increment_current_active_connections_stat() override;
void decrement_current_active_connections_stat() override;

// Implement ProxySession interface
const char *get_protocol_string() const override;

QPACK *local_qpack();
QPACK *remote_qpack();

Expand Down