Skip to content

Conversation

@jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 3, 2023

The re-introduction of the MTHashTable class created a dependency from tscore to iocore, since it uses proxy mutexes, which are tightly coupled to the event system. We can break this circular dependency by moving the class into the QUIC library as an implementation detail, since that already depends on the event system

This fixes #9768.

The re-introduction of the MTHashTable class created a dependency from
tscore to iocore, since it uses proxy mutexes, which are tightly coupled
to the event system. We can break this circular dependency by moving
the class into the QUIC library as an implementation detail, since that
already depends on the event system

This fixes apache#9768.

Signed-off-by: James Peach <jpeach@apache.org>
@jpeach
Copy link
Contributor Author

jpeach commented Jun 5, 2023

     Setting up : Copying '/home/jenkins/workspace/Github_Builds/autest/src/tests/gold_tests/pluginTest/polite_hook_wait/.libs/polite_hook_wait.so' to '/tmp/sandbox/polite_hook_wait/ts/plugin' - Passed
     Test : Checking that ReturnCode == 0 - Failed
        Reason: Returned Value -9 != 0
     Time-Out : Process finishes within expected time - Passed
        Reason: Returned value: 10.503296613693237 < 600.0

Seems like a CI problem?

@jpeach
Copy link
Contributor Author

jpeach commented Jun 5, 2023

Wait, the copy isn't the error, I guess it's a return code check from this somewhere?

tr = Test.AddTestRun()
tr.Processes.Default.StartBefore(server)
tr.Processes.Default.StartBefore(ts)
tr.Processes.Default.Command = (
    'curl --verbose --ipv4 --header "Host:myhost.test" http://localhost:{}/ 2>curl.txt'.format(ts.Variables.port)
)
tr.Processes.Default.ReturnCode = 0

tr = Test.AddTestRun()
tr.Processes.Default.Command = (
    'curl --verbose --ipv4 --header "Host:myhost.test" http://localhost:{}/ 2>curl.txt'.format(ts.Variables.port)
)
tr.Processes.Default.ReturnCode = 0

tr = Test.AddTestRun()
tr.Processes.Default.Command = "grep -F HTTP/ curl.txt"
tr.Processes.Default.Streams.stdout = "curl.gold"
tr.Processes.Default.ReturnCode = 0

But it's not clear which one fails or why. Exit code 9 from curl is " FTP access denied", so maybe it's the grep that fails? If there's an expected output file, I wonder why the test runs grep manually?

@jpeach
Copy link
Contributor Author

jpeach commented Jun 5, 2023

[approve ci autest]

Copy link
Contributor

@cmcfarlen cmcfarlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

@bryancall bryancall added the Core label Jun 5, 2023
@bryancall bryancall added this to the 10.0.0 milestone Jun 5, 2023
@jpeach jpeach merged commit eb09664 into apache:master Jun 5, 2023
@jpeach jpeach deleted the move-mt-hashtable branch June 5, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular dependency between iocore and tscore

6 participants