Skip to content

Remove unneeded DEBUG conditionals. #9849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpeach merged 1 commit into from
Jun 15, 2023
Merged

Remove unneeded DEBUG conditionals. #9849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions iocore/eventsystem/I_Action.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class Action
machine.

*/
int cancelled = false;
bool cancelled = false;

/**
Cancels the asynchronous operation represented by this action.
Expand All @@ -141,14 +141,8 @@ class Action
cancel(Continuation *c = nullptr)
{
ink_assert(!c || c == continuation);
#ifdef DEBUG
ink_assert(!cancelled);
cancelled = true;
#else
if (!cancelled) {
cancelled = true;
}
#endif
}

/**
Expand All @@ -166,14 +160,8 @@ class Action
cancel_action(Continuation *c = nullptr)
{
ink_assert(!c || c == continuation);
#ifdef DEBUG
ink_assert(!cancelled);
cancelled = true;
#else
if (!cancelled) {
cancelled = true;
}
#endif
}

Continuation *
Expand Down