Add support for quic to CMake build #9892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahWI
force-pushed
the
feat/cmake-quiche
branch
8 times, most recently
from
23a2ada to
056323c
Compare
This adds an option that defaults to OFF: ENABLE_QUICHE. When quiche is enabled, the quic static library and the http3 static library will be built and linked appropriately. The traffic_quic executable will also be built. It also does some cleanup of targets in the CMake build. Some targets are now namespaced in ts:: to make it explicit which targets are part of trafficserver, and to make usage style consistent with that of third-party libraries. Some dependencies have also been corrected, and comments added where dependencies are misrepresented by necessity.
JosiahWI
force-pushed
the
feat/cmake-quiche
branch
from
056323c to
904bcec
Compare
JosiahWI
added
Build
maskit
reviewed
Jun 21, 2023
maskit
reviewed
Jun 21, 2023
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
Looks good to me but I'll leave this for CMake users.
Contributor
Author
|
Test "TSVConnFD" failed with code -9. |
Contributor
|
[approve ci rocky] |
cmcfarlen
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option that defaults to OFF: ENABLE_QUICHE. When quiche is enabled, the quic static library and the http3 static library will be built and linked appropriately. The traffic_quic executable will also be built.
It also does some cleanup of targets in the CMake build. Some targets are now namespaced in ts:: to make it explicit which targets are part of trafficserver, and to make usage style consistent with that of third-party libraries. Some dependencies have also been corrected, and comments added where dependencies are misrepresented by necessity.
I opened this PR after consulting with @bryancall. It is an alternative to #9833, and part of it is taken from that PR (albeit heavily modified).