Move URL escapify functions into tscore #9919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jeff Elsloo <elsloo@apache.org>
bneradt
requested changes
Jun 27, 2023
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. Probably good to add ending newlines for the new files though. If you're using vscode, this might be helpful:
bneradt
approved these changes
Jun 28, 2023
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Sep 26, 2023
Co-authored-by: Jeff Elsloo <elsloo@apache.org> (cherry picked from commit 67a8783) Conflicts: src/tscore/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for escaping URL is currently in
proxy/loggingbut it's not logging specific and it should be useful for other modules. This PR moves the logic into tscore, and add some unit tests.I have WIP code for OCSP GET request, which is in
iocore/net, and it relies on this change (URL escapify is needed to send OCSP request as a query string).Co-Authored-By: Jeff Elsloo elsloo@apache.org