feature/unittests

cpp/CMakeLists.txt

@@ -73,3 +73,6 @@ configure_file(
   "${PROJECT_SOURCE_DIR}/cmake/config.h.in"
   "${PROJECT_BINARY_DIR}/cmake_config.h"
 )
+
+add_subdirectory(test)
+add_dependencies(TsFile_Test tsfile)

cpp/pom.xml

@@ -88,7 +88,7 @@
                             <goal>test</goal>
                         </goals>
                         <configuration>
-                            <buildDirectory>${project.build.directory}/build</buildDirectory>
+                            <buildDirectory>${project.build.directory}/build/test</buildDirectory>
                         </configuration>
                     </execution>
                 </executions>

cpp/src/common/allocator/byte_stream.h

@@ -220,7 +220,7 @@ FORCE_INLINE double bytes_to_double(uint8_t bytes[8]) {
 
     // follow jdk implementation style.
     union {
-        long l;
+        long long l;
         double d;
     } u;
 

cpp/src/common/container/array.h

@@ -230,7 +230,7 @@ class Array {
     }
 
     bool contain(const ValueType &value) {
-        for (int i = 0; i < size_; i++) {
+        for (size_t i = 0; i < size_; i++) {
             if (array_[i] == value) {
                 return true;
             }

cpp/src/common/container/hash_table.h

@@ -333,7 +333,7 @@ class HashTable {
 
         if (ATOMIC_LOAD(&size_) > ATOMIC_LOAD(&new_table_capacity_) *
                                       SEGMENT_CAPACITY * TABLE_GROWTH) {
-            int tmp = 0;
+            uint8_t tmp = 0;
             if (ATOMIC_CAS(&is_extending_, &tmp, 1)) {
                 ret = extend();
                 if (ret != E_OK) {
@@ -437,7 +437,7 @@ class HashTable {
 
         if (ATOMIC_LOAD(&size_) > ATOMIC_LOAD(&new_table_capacity_) *
                                       SEGMENT_CAPACITY * TABLE_GROWTH) {
-            int tmp = 0;
+            uint8_t tmp = 0;
             if (ATOMIC_CAS(&is_extending_, &tmp, 1)) {
                 ret = extend();
                 if (ret != E_OK) {

cpp/src/common/container/simple_vector.h

@@ -19,6 +19,8 @@
 #ifndef COMMON_CONTAINER_VECTOR_H
 #define COMMON_CONTAINER_VECTOR_H
 
+#include <vector>
+
 #include "utils/util_define.h"
 
 namespace common {

cpp/src/common/datatype/value.h

@@ -221,4 +221,4 @@ FORCE_INLINE int get_typed_data_from_value<double>(Value *value,
 
 }  // namespace common
 
-#endif  // COMMON_DATATYPE_VALUE_H
+#endif  // COMMON_DATATYPE_VALUE_H

cpp/src/encoding/bitpack_decoder.h

@@ -43,8 +43,8 @@ class BitPackDecoder {
 
    public:
     BitPackDecoder()
-        : byte_cache_(1024, common::MOD_DECODER_OBJ),
-          current_count_(0),
+        : current_count_(0),
+          byte_cache_(1024, common::MOD_DECODER_OBJ),
           current_buffer_(nullptr),
           packer_(nullptr),
           tmp_buf_(nullptr) {}

cpp/src/encoding/bitpack_encoder.h

@@ -73,7 +73,7 @@ class BitPackEncoder {
 
     FORCE_INLINE void encode(int64_t value, common::ByteStream &out) {
         values_.push_back(value);
-        int current_bit_width = 32 - number_of_leading_zeros(value);
+        int current_bit_width = 64 - number_of_leading_zeros(value);
         if (current_bit_width > bit_width_) {
             bit_width_ = current_bit_width;
         }

cpp/src/encoding/plain_decoder.h

@@ -20,7 +20,7 @@
 #ifndef ENCODING_PLAIN_DECODER_H
 #define ENCODING_PLAIN_DECODER_H
 
-#include "decoder.h"
+#include "encoding/decoder.h"
 
 namespace storage {
 

cpp/test/CMakeLists.txt

@@ -0,0 +1,54 @@
+#[[
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+    https://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+]]
+include(FetchContent)
+FetchContent_Declare(
+  googletest
+  URL https://github.com/google/googletest/archive/refs/tags/v1.12.0.zip
+)
+set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
+FetchContent_MakeAvailable(googletest)
+
+set(SDK_INCLUDE_DIR ${PROJECT_SOURCE_DIR}/../src)
+message("SDK_INCLUDE_DIR: ${SDK_INCLUDE_DIR}")
+set(LIBTSFILE_SDK_DIR ${PROJECT_BINARY_DIR}/lib)
+message("LIBTSFILE_SDK_DIR: ${LIBTSFILE_SDK_DIR}")
+
+include_directories(${SDK_INCLUDE_DIR})
+
+enable_testing()
+
+file(GLOB_RECURSE TEST_SRCS
+        "common/*_test.cc"
+        "encoding/*_test.cc"
+        "utils/*_test.cc"
+        "file/*_test.cc"
+        "compress/*_test.cc"
+        "writer/*_test.cc"
+        )
+add_executable(TsFile_Test ${TEST_SRCS})
+target_link_libraries(
+  TsFile_Test
+  GTest::gtest_main
+  GTest::gmock
+  tsfile
+)
+set_target_properties(TsFile_Test PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${LIBTSFILE_SDK_DIR})
+
+include(GoogleTest)
+gtest_discover_tests(TsFile_Test)

cpp/test/common/allocator/alloc_base_test.cc

@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License a
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#include "common/allocator/alloc_base.h"
+
+#include <gtest/gtest.h>
+
+namespace common {
+
+const uint32_t HEADER_SIZE_4B = 4;
+const uint32_t HEADER_SIZE_8B = 8;
+
+TEST(AllocBaseTest, BaseAllocator) {
+    BaseAllocator allocator;
+    for (AllocModID mod_id = MOD_DEFAULT; mod_id <= MOD_ZIGZAG_OBJ;
+         mod_id = (AllocModID)(mod_id + 1)) {
+        void *ptr = allocator.alloc(100, mod_id);
+        ASSERT_NE(ptr, nullptr);
+        allocator.free(ptr);
+    }
+}
+
+TEST(AllocBaseTest, AllocSmallSize) {
+    uint32_t size = 1024;
+    AllocModID mid = MOD_DEFAULT;
+    void *ptr = mem_alloc(size, mid);
+    ASSERT_NE(ptr, nullptr);
+    char *p = (char *)ptr - HEADER_SIZE_4B;
+    uint32_t header = *((uint32_t *)p);
+    EXPECT_EQ(header >> 8, size);
+    EXPECT_EQ(header & 0x7F, mid);
+    mem_free(ptr);
+}
+
+TEST(AllocBaseTest, AllocLargeSize) {
+    uint32_t size = 0x1000000;
+    AllocModID mid = MOD_DEFAULT;
+    void *ptr = mem_alloc(size, mid);
+    ASSERT_NE(ptr, nullptr);
+    char *p = (char *)ptr - HEADER_SIZE_8B;
+    uint32_t high4b = *(uint32_t *)p;
+    uint32_t low4b = *(uint32_t *)(p + 4);
+    uint64_t header = ((uint64_t)high4b << 32) | low4b;
+    EXPECT_EQ((header >> 8), size);
+    EXPECT_EQ((header & 0x7F), mid);
+    mem_free(ptr);
+}
+
+}  // namespace common