support C wrapper for tsfile v4. #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
requested changes
Jan 25, 2025
| /*--------------------------TsFile Writer Register------------------------ */ | ||
| void tsfile_writer_register_table(TsFileWriter writer, TableSchema* schema); | ||
| ERRNO tsfile_writer_register_timeseries(TsFileWriter writer, | ||
| const char* device_name, |
There was a problem hiding this comment.
device_name -> device_id
| TableSchema tsfile_reader_get_table_schema(TsFileReader reader, | ||
| const char* table_name); | ||
| DeviceSchema tsfile_reader_get_timeseries_schema(TsFileReader reader, const char* device_id); | ||
|
|
There was a problem hiding this comment.
TableSchema* tsfile_reader_get_all_table_schemas(TsFileReader reader, uint32_t* size)
| // destroy pointer | ||
| ERRNO destroy_tsfile_ts_record(TsRecord record); | ||
| ERRNO destroy_tablet(Tablet tablet); | ||
| void destroy_tsfile_result_set(ResultSet result_set); |
There was a problem hiding this comment.
The operation name on ResultSet is more often "close" rather than "destroy."
| /*--------------------------TsFile Reader and Writer------------------------ */ | ||
| TsFileReader tsfile_reader_new(const char* pathname, ERRNO* err_code); | ||
| TsFileWriter tsfile_writer_new(const char* pathname, ERRNO* err_code); | ||
| TsFileWriter tsfile_writer_open_conf(const char* pathname, mode_t flag, |
There was a problem hiding this comment.
tsfile_writer_new_with_conf?
| auto reader = new storage::TsFileReader(); | ||
| int ret = reader->open(pathname); | ||
| if (ret != common::E_OK) { | ||
| std::cout << "open file failed" << std::endl; |
There was a problem hiding this comment.
Remove or replace with LOG and add in other functions.
Comment on lines
+175
to
+181
| Expression* and_filter_to_and_query(Expression* exp_and, Expression* exp) { | ||
| if (exp_and->children_length >= MAX_COLUMN_FILTER_NUM - 1) { | ||
| return nullptr; | ||
| } | ||
| exp_and->children[exp_and->children_length++] = exp; | ||
| return exp_and; | ||
| } |
There was a problem hiding this comment.
and_filter_to_and_query -> add_filter_to_and_filter
| } ExpressionType; | ||
|
|
||
| typedef struct constant { | ||
| int64_t value_condition; |
There was a problem hiding this comment.
How about using a union?
| char** column_names; | ||
| int column_num; | ||
| QueryDataRetINTERNAL data; | ||
| }* QueryDataRet; |
There was a problem hiding this comment.
QueryDataRet -> ResultSet
| int children_length; | ||
| } Expression; | ||
|
|
||
| typedef Tablet DataResult; |
Comment on lines
+116
to
+121
| for (int i = 0; i < measurement_num - 1; i++) { | ||
| ASSERT_TRUE(tsfile_result_set_has_next(result_set)); | ||
| ASSERT_FALSE(tsfile_result_set_is_null_by_index(result_set,i)); | ||
| ASSERT_EQ(tsfile_result_set_get_value_by_index_int64_t(result_set, i), i*2); | ||
| ASSERT_EQ(tsfile_result_set_get_value_by_name_int64_t(result_set, std::string("measurement" + std::to_string(i)).c_str()), i*2); | ||
| } |
There was a problem hiding this comment.
Better to check the whole data set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.