Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more interface #391

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Add more interface #391

merged 1 commit into from
Feb 6, 2025

Conversation

JackieTien97
Copy link
Contributor

  1. make TsFileSequenceReader return AbstractAlignedChunkMetadata instead of AlignedChunkMetadata
  2. add createNewChunkMetadata method in AbstractAlignedChunkMetadata to return create exact subClass, avoid caller using instanceof to do that

Verified

This commit was signed with the committer’s verified signature.
h3ndrk Hendrik
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.87%. Comparing base (59b8d0b) to head (da4872d).

Files with missing lines Patch % Lines
...che/tsfile/file/metadata/AlignedChunkMetadata.java 0.00% 1 Missing ⚠️
...tsfile/file/metadata/TableDeviceChunkMetadata.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #391      +/-   ##
===========================================
- Coverage    64.87%   64.87%   -0.01%     
===========================================
  Files          545      545              
  Lines        33118    33120       +2     
  Branches      4409     4409              
===========================================
  Hits         21486    21486              
- Misses       11090    11092       +2     
  Partials       542      542              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 03c3aa6 into develop Feb 6, 2025
14 checks passed
@JackieTien97 JackieTien97 deleted the change branch February 6, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants