Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
  • Loading branch information
driazati committed Jun 15, 2022
1 parent b330d8c commit 4035ab9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 15 deletions.
8 changes: 4 additions & 4 deletions tests/lint/pylint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
# under the License.
set -euxo pipefail

python3 -m pylint python/tvm --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint vta/python/vta --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/unittest/test_tvmscript_type.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_cmsisnn --rcfile="$(dirname "$0")"/pylintrc
# python3 -m pylint python/tvm --rcfile="$(dirname "$0")"/pylintrc
# python3 -m pylint vta/python/vta --rcfile="$(dirname "$0")"/pylintrc
# python3 -m pylint tests/python/unittest/test_tvmscript_type.py --rcfile="$(dirname "$0")"/pylintrc
# python3 -m pylint tests/python/contrib/test_cmsisnn --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/ci --rcfile="$(dirname "$0")"/pylintrc

16 changes: 5 additions & 11 deletions tests/python/ci/test_ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def test_ping_reviewers(tmpdir_factory):
"""
reviewers_script = REPO_ROOT / "tests" / "scripts" / "ping_reviewers.py"

def run(pr, check): # pylint: disable=invalid-name
def run(pull_request, check):
git = TempGit(tmpdir_factory.mktemp("tmp_git_dir"))
# Jenkins git is too old and doesn't have 'git init --initial-branch'
git.run("init")
Expand All @@ -357,7 +357,7 @@ def run(pr, check): # pylint: disable=invalid-name
"data": {
"repository": {
"pullRequests": {
"nodes": [pr],
"nodes": [pull_request],
"edges": [],
}
}
Expand Down Expand Up @@ -721,15 +721,9 @@ def run(source_type, data, check):
"login": "person5",
},
"labels": [{"name": "something2"}],
# pylint: disable=line-too-long
"body": textwrap.dedent(
"""
`mold` and `lld` can be a much faster alternative to `ld` from gcc. We should modify our CMakeLists.txt to detect and use these when possible. cc @person1
cc @person4
"""
),
# pylint: enable=line-too-long
"body": "`mold` and `lld` can be a much faster alternative to `ld` from gcc. "
"We should modify our CMakeLists.txt to detect and use these when possible. cc @person1"
"\n\ncc @person4",
},
check="would have updated issues/1234 with {'body': '\\n`mold` and `lld` can be a much"
" faster alternative to `ld` from gcc. We should modify our CMakeLists.txt to "
Expand Down

0 comments on commit 4035ab9

Please sign in to comment.