address matthew's comments

apache · Apr 30, 2021 · 6e470d2 · 6e470d2
1 parent 634253a
commit 6e470d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/tests/python/contrib/test_arm_compute_lib/test_pooling.py b/tests/python/contrib/test_arm_compute_lib/test_pooling.py
@@ -32,12 +32,10 @@
 
 def _calculate_output_shape(shape, sizes, padding, strides, dilation):
     """Calculate pooling output shape."""
-    output_height = (
-        (shape[1] - (sizes[0] - 1) * dilation[0] - 1 + padding[0] + padding[2]) / strides[0]
-    ) + 1
-    output_width = (
-        (shape[2] - (sizes[1] - 1) * dilation[1] - 1 + padding[1] + padding[3]) / strides[1]
-    ) + 1
+    height_receptive_field = (sizes[0] - 1) * dilation[0] + 1
+    width_receptive_field = (sizes[1] - 1) * dilation[1] + 1
+    output_height = ((shape[1] - height_receptive_field + padding[0] + padding[2]) / strides[0]) + 1
+    output_width = ((shape[2] - width_receptive_field + padding[1] + padding[3]) / strides[1]) + 1
     return 1, int(output_height), int(output_width), shape[3]
 
 

diff --git a/tests/python/relay/test_op_level5.py b/tests/python/relay/test_op_level5.py
@@ -671,10 +671,10 @@ def verify_roi_align(
             print("test on", target)
             intrp1 = relay.create_executor("graph", device=dev, target=target)
             op_res1 = intrp1.evaluate(func)(np_data, np_rois)
-            tvm.testing.assert_allclose(op_res1.asnumpy(), ref_res, rtol=2e-4)
+            tvm.testing.assert_allclose(op_res1.asnumpy(), ref_res, rtol=1e-4)
             intrp2 = relay.create_executor("debug", device=dev, target=target)
             op_res2 = intrp2.evaluate(func)(np_data, np_rois)
-            tvm.testing.assert_allclose(op_res2.asnumpy(), ref_res, rtol=2e-4)
+            tvm.testing.assert_allclose(op_res2.asnumpy(), ref_res, rtol=1e-4)
 
     def verify_roi_align_nchw(
         data_shape, rois_shape, pooled_size, spatial_scale, sample_ratio, mode