respond to review comments

apache · Sep 25, 2020 · 795422f · 795422f
1 parent 664a055
commit 795422f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 20 deletions.
diff --git a/python/tvm/autotvm/record.py b/python/tvm/autotvm/record.py
@@ -152,7 +152,7 @@ def decode(row, protocol="json"):
         tgt, task_name, task_args, task_kwargs = row["input"]
         tgt = str(tgt)
         if "-target" in tgt:
-            # logger.warning('"-target" is deprecated, use "-mtriple" instead.')
+            logger.warning('"-target" is deprecated, use "-mtriple" instead.')
             tgt = tgt.replace("-target", "-mtriple")
         tgt = Target(str(tgt))
 

diff --git a/python/tvm/relay/frontend/onnx.py b/python/tvm/relay/frontend/onnx.py
@@ -17,7 +17,6 @@
 # pylint: disable=invalid-name, import-self, len-as-condition, unused-argument, too-many-lines
 # pylint: disable=import-outside-toplevel
 """ONNX: Open Neural Network Exchange frontend for Relay."""
-import logging
 import numpy as np
 import tvm
 from tvm.ir import IRModule
@@ -34,8 +33,6 @@
 from .common import infer_type, get_name
 
 
-logger = logging.getLogger("onnx_frontend")
-
 __all__ = ["from_onnx"]
 
 
@@ -257,11 +254,8 @@ def _impl_v1(cls, inputs, attr, params):
                     pad_tuple = tuple([val for pair in zip(*pad_tuple) for val in pair])
                     attr["pads"] = pad_tuple
                 else:
-                    warning = (
-                        "Performing dynamic autopadding on Pool. "
-                        + "Pool kernels don't currently support dynamic shapes."
-                    )
-                    logger.warning(warning)
+                    # Warning: Pool does not yet support dynamic shapes,
+                    # one will need to run dynamic_to_static on this model after import
                     data = autopad(data, attr["strides"], attr["kernel_shape"], [1] * ndim, ndim)
             elif attr["auto_pad"] == "VALID":
                 attr["pads"] = tuple([0 for i in range(ndim - 2)])
@@ -386,7 +380,8 @@ def _impl_v1(cls, inputs, attr, params):
                     "Performing dynamic autopadding on Conv. "
                     + "Conv kernels don't currently support dynamic shapes."
                 )
-                logger.warning(warning)
+                # Warning: Convolution does not yet support dynamic shapes,
+                # one will need to run dynamic_to_static on this model after import
                 data = autopad(data, attr["strides"], attr["kernel_shape"], attr["dilations"], ndim)
             elif attr["auto_pad"] == "VALID":
                 attr["pads"] = tuple([0 for i in range(ndim - 2)])
@@ -442,11 +437,8 @@ def _impl_v1(cls, inputs, attr, params):
         if "auto_pad" in attr:
             attr["auto_pad"] = attr["auto_pad"].decode("utf-8")
             if attr["auto_pad"] in ("SAME_UPPER", "SAME_LOWER"):
-                warning = (
-                    "Performing dynamic autopadding on ConvTranspose. "
-                    + "ConvTranspose kernels don't currently support dynamic shapes."
-                )
-                logger.warning(warning)
+                # Warning: Convolution does not yet support dynamic shapes,
+                # one will need to run dynamic_to_static on this model after import
                 data = autopad(
                     data,
                     attr["strides"],
@@ -616,11 +608,8 @@ def _impl_v1(cls, inputs, attr, params):
         if "auto_pad" in attr:
             attr["auto_pad"] = attr["auto_pad"].decode("utf-8")
             if attr["auto_pad"] in ("SAME_UPPER", "SAME_LOWER"):
-                warning = (
-                    "Performing dynamic autopadding on LpPool. "
-                    + "LpPool kernels don't currently support dynamic shapes."
-                )
-                logger.warning(warning)
+                # Warning: LpPool does not yet support dynamic shapes,
+                # one will need to run dynamic_to_static on this model after import
                 data = autopad(data, attr["strides"], attr["kernel_shape"], [1] * ndim, ndim)
             elif attr["auto_pad"] == "VALID":
                 attr["pads"] = tuple([0 for i in range(ndim - 2)])