address comment

apache · Jul 10, 2020 · b012904 · b012904
1 parent 12312f5
commit b012904
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/relay/backend/contrib/codegen_json/codegen_json.h b/src/relay/backend/contrib/codegen_json/codegen_json.h
@@ -104,7 +104,7 @@ class OpAttrExtractor : public AttrVisitor {
           attr.push_back(Fp2String(fm->value));
         } else if (const auto* str = (*an)[i].as<StringObj>()) {
           String s = GetRef<String>(str);
-          attr.push_back(s.operator std::string());
+          attr.push_back(s);
         } else {
           LOG(FATAL) << "Not supported type: " << (*an)[i]->GetTypeKey();
         }
@@ -118,7 +118,7 @@ class OpAttrExtractor : public AttrVisitor {
       SetNodeAttr(key, std::vector<std::string>{Fp2String(fm->value)});
     } else if (const auto* str = (*value).as<StringObj>()) {
       String s = GetRef<String>(str);
-      SetNodeAttr(key, std::vector<std::string>{s.operator std::string()});
+      SetNodeAttr(key, std::vector<std::string>{s});
     } else {
       LOG(FATAL) << "Not yet supported type: " << (*value)->GetTypeKey() << ": " << *value;
     }
@@ -230,7 +230,7 @@ class JSONSerializer : public MemoizedExprTranslator<std::vector<JSONGraphNodeEn
       auto pattern = fn->GetAttr<String>(attr::kPartitionedFromPattern);
       CHECK(pattern.defined());
       std::vector<std::string> values;
-      values.push_back(pattern.value().operator std::string());
+      values.push_back(pattern.value());
       std::vector<dmlc::any> attr;
       attr.emplace_back(values);
       node->SetAttr("PartitionedFromPattern", attr);
@@ -271,7 +271,7 @@ class JSONSerializer : public MemoizedExprTranslator<std::vector<JSONGraphNodeEn
     } else if (const auto* fn = cn->op.as<FunctionNode>()) {
       auto comp = fn->GetAttr<String>(attr::kComposite);
       CHECK(comp.defined()) << "JSON runtime only supports composite functions.";
-      name = comp.value().operator std::string();
+      name = comp.value();
     } else {
       LOG(FATAL) << "JSON runtime does not support calls to " << cn->op->GetTypeKey();
     }

diff --git a/src/relay/backend/contrib/dnnl/codegen.cc b/src/relay/backend/contrib/dnnl/codegen.cc
@@ -442,7 +442,7 @@ class DNNLJSONSerializer : public backend::contrib::JSONSerializer {
     } else if (const auto* fn = cn->op.as<FunctionNode>()) {
       auto comp = fn->GetAttr<String>(attr::kComposite);
       CHECK(comp.defined()) << "DNNL JSON runtime only supports composite functions.";
-      name = comp.value().operator std::string();
+      name = comp.value();
 
       if (name == "dnnl.conv2d_bias_relu") {
         call = GetRootCall(fn->body.as<CallNode>(), 2, {"nn.conv2d", "add", "nn.relu"});

diff --git a/src/runtime/contrib/dnnl/dnnl_json_runtime.cc b/src/runtime/contrib/dnnl/dnnl_json_runtime.cc
@@ -136,7 +136,7 @@ class DNNLJSONRuntime : public JSONRuntimeBase {
                               size_t offset = 0) {
     auto eid = EntryID(entry);
     // Since the DNNL memory has been created before calling this function, we assume the entry
-    // has not yet been bind to the other DNNL memory; otherwise it may have memory leak.
+    // has not yet been bound to the other DNNL memory; otherwise it may have memory leak.
     CHECK_EQ(entry_out_mem_.count(eid), 0);
 
     // TODO(@comanic): Support other data types (i.e., int8).