-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Address comments: test cases, code cleanups
- Loading branch information
Showing
13 changed files
with
733 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
tests/python/ci/sample_prs/pr10786-changes-requested.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| { | ||
| "title": "[Hexagon] 2-d allocation cleanup", | ||
| "body": "- Added device validity check in allocation. HexagonDeviceAPI should only be called for CPU/Hexagon types.\r\n\r\n- Check for \"global.vtcm\" scope instead of \"vtcm\". The ccope of N-d allocations produced by `LowerVtcmAlloc` should be `\"global.vtcm\"`. The previous check allowed unsupported scope such as `\"local.vtcm\"`.\r\n\r\n- Remove `vtcmallocs` entry after calling free. Previously, the vtcm allocation map kept dangling pointers to `HexagonBuffer` objects after they had been freed.\r\n\r\n- Rename N-d alloc and free packed functions. Since most of the similar device functions use snake case, renaming `*.AllocND` to `*.alloc_nd` and `*.FreeND` to `*.free_nd`.\r\n\r\nCo-authored-by: Adam Straw <astraw@octoml.ai>", | ||
| "state": "OPEN", | ||
| "author": { | ||
| "login": "Lunderberg" | ||
| }, | ||
| "comments": { | ||
| "pageInfo": { | ||
| "hasPreviousPage": false | ||
| }, | ||
| "nodes": [] | ||
| }, | ||
| "authorCommits": { | ||
| "nodes": [ | ||
| { | ||
| "commit": { | ||
| "authors": { | ||
| "nodes": [ | ||
| { | ||
| "name": "Eric Lunderberg", | ||
| "email": "elunderberg@octoml.ai" | ||
| }, | ||
| { | ||
| "name": "Adam Straw", | ||
| "email": "astraw@octoml.ai" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "commits": { | ||
| "nodes": [ | ||
| { | ||
| "commit": { | ||
| "oid": "6f04bcf57d07f915a98fd91178f04d9e92a09fcd", | ||
| "statusCheckRollup": { | ||
| "contexts": { | ||
| "pageInfo": { | ||
| "hasNextPage": false | ||
| }, | ||
| "nodes": [ | ||
| { | ||
| "name": "MacOS", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "CI" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945392" | ||
| }, | ||
| { | ||
| "name": "cc-reviewers", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "PR" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945029" | ||
| }, | ||
| { | ||
| "name": "tag-teams", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "Teams" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945030" | ||
| }, | ||
| { | ||
| "name": "Windows", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "CI" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945524" | ||
| }, | ||
| { | ||
| "state": "SUCCESS", | ||
| "context": "tvm-ci/pr-head", | ||
| "targetUrl": "https://ci.tlcpack.ai/job/tvm/job/PR-10786/1/display/redirect" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "reviewDecision": "CHANGES_REQUESTED", | ||
| "reviews": { | ||
| "pageInfo": { | ||
| "hasPreviousPage": false | ||
| }, | ||
| "nodes": [ | ||
| { | ||
| "body": "@tvm-bot merge", | ||
| "updatedAt": "2022-03-25T22:13:50Z", | ||
| "url": "https://github.com/apache/tvm/pull/10786#pullrequestreview-922186273", | ||
| "authorCanPushToRepository": true, | ||
| "commit": { | ||
| "oid": "6f04bcf57d07f915a98fd91178f04d9e92a09fcd" | ||
| }, | ||
| "author": { | ||
| "login": "kparzysz-quic" | ||
| }, | ||
| "state": "CHANGES_REQUESTED" | ||
| } | ||
| ] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| { | ||
| "title": "[Hexagon] 2-d allocation cleanup", | ||
| "body": "- Added device validity check in allocation. HexagonDeviceAPI should only be called for CPU/Hexagon types.\r\n\r\n- Check for \"global.vtcm\" scope instead of \"vtcm\". The ccope of N-d allocations produced by `LowerVtcmAlloc` should be `\"global.vtcm\"`. The previous check allowed unsupported scope such as `\"local.vtcm\"`.\r\n\r\n- Remove `vtcmallocs` entry after calling free. Previously, the vtcm allocation map kept dangling pointers to `HexagonBuffer` objects after they had been freed.\r\n\r\n- Rename N-d alloc and free packed functions. Since most of the similar device functions use snake case, renaming `*.AllocND` to `*.alloc_nd` and `*.FreeND` to `*.free_nd`.\r\n\r\nCo-authored-by: Adam Straw <astraw@octoml.ai>", | ||
| "state": "OPEN", | ||
| "author": { | ||
| "login": "Lunderberg" | ||
| }, | ||
| "comments": { | ||
| "pageInfo": { | ||
| "hasPreviousPage": false | ||
| }, | ||
| "nodes": [] | ||
| }, | ||
| "authorCommits": { | ||
| "nodes": [ | ||
| { | ||
| "commit": { | ||
| "authors": { | ||
| "nodes": [ | ||
| { | ||
| "name": "Eric Lunderberg", | ||
| "email": "elunderberg@octoml.ai" | ||
| }, | ||
| { | ||
| "name": "Some One", | ||
| "email": "someone@email.com" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "commits": { | ||
| "nodes": [ | ||
| { | ||
| "commit": { | ||
| "oid": "6f04bcf57d07f915a98fd91178f04d9e92a09fcd", | ||
| "statusCheckRollup": { | ||
| "contexts": { | ||
| "pageInfo": { | ||
| "hasNextPage": false | ||
| }, | ||
| "nodes": [ | ||
| { | ||
| "name": "MacOS", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "CI" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945392" | ||
| }, | ||
| { | ||
| "name": "cc-reviewers", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "PR" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945029" | ||
| }, | ||
| { | ||
| "name": "tag-teams", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "Teams" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945030" | ||
| }, | ||
| { | ||
| "name": "Windows", | ||
| "checkSuite": { | ||
| "workflowRun": { | ||
| "workflow": { | ||
| "name": "CI" | ||
| } | ||
| } | ||
| }, | ||
| "status": "COMPLETED", | ||
| "conclusion": "SUCCESS", | ||
| "url": "https://github.com/apache/tvm/runs/5694945524" | ||
| }, | ||
| { | ||
| "state": "SUCCESS", | ||
| "context": "tvm-ci/pr-head", | ||
| "targetUrl": "https://ci.tlcpack.ai/job/tvm/job/PR-10786/1/display/redirect" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "reviewDecision": "APPROVED", | ||
| "reviews": { | ||
| "pageInfo": { | ||
| "hasPreviousPage": false | ||
| }, | ||
| "nodes": [ | ||
| { | ||
| "body": "@tvm-bot merge", | ||
| "updatedAt": "2022-03-25T22:13:50Z", | ||
| "authorCanPushToRepository": true, | ||
| "commit": { | ||
| "oid": "6f04bcf57d07f915a98fd91178f04d9e92a09fcd" | ||
| }, | ||
| "author": { | ||
| "login": "kparzysz-quic" | ||
| }, | ||
| "state": "APPROVED" | ||
| } | ||
| ] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.