dyn slice tests left as todo now work

apache · May 27, 2021 · e79931a · e79931a
1 parent 7db4cea
commit e79931a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tests/python/relay/test_op_level4.py b/tests/python/relay/test_op_level4.py
@@ -483,9 +483,8 @@ def verify(dshape, begin, end, strides, output, slice_mode="end", test_ref=True,
     verify((3, 4, 3), [1, 1, 0], [4, 1000, 3], None, (2, 3, 3))
     verify((3, 4, 3), [1, 1, 0], [4, 4, 4], None, (2, 3, 3))
     verify((3, 4, 3), [1, 1, 0], [4, 4, 3], None, (2, 3, 3))
-    # TODO(mbrookhart): fix static strided_slice with dynamic input and negative begin
-    # verify((3, 4, 3), [1, -1, 0], [4, -5, 3], [2, -1, 1], (1, 4, 3))
-    # verify((3, 4, 3), [1, -1, 0], [2, -3, 3], [1, -1, 1], (1, 2, 3))
+    verify((3, 4, 3), [1, -1, 0], [4, -5, 3], [2, -1, 1], (1, 4, 3))
+    verify((3, 4, 3), [1, -1, 0], [2, -3, 3], [1, -1, 1], (1, 2, 3))
     verify(
         (3, 4, 3), [1, 0, 0], [3, -1, 3], [1, 1, 1], (2, 4, 3), slice_mode="size", test_ref=False
     )
@@ -534,6 +533,7 @@ def verify(dshape, begin, end, strides, vshape, test_ref=True):
 
 if __name__ == "__main__":
     test_strided_slice()
+    test_dyn_strided_slice()
     test_strided_set()
     test_binary_op()
     test_cmp_type()