Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] test_cmsisnn/test_conv2d.py #10314

Closed
driazati opened this issue Feb 18, 2022 · 0 comments
Closed

[Flaky Test] test_cmsisnn/test_conv2d.py #10314

driazati opened this issue Feb 18, 2022 · 0 comments
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it test: flaky

Comments

@driazati
Copy link
Member

driazati commented Feb 18, 2022 •
edited
Loading

These tests were found to be flaky (intermittently failing on main or failed in a PR with unrelated changes). As per the docs, these failures will be disabled in a PR that references this issue until the test owners can fix the source of the flakiness.

Test(s)

  • tests/python/contrib/test_cmsisnn/test_conv2d.py::test_conv2d_asymmetric_padding_int8
  • tests/python/contrib/test_cmsisnn/test_conv2d.py::test_depthwise_int8

Jenkins Links

cc @ashutosh-arm
@driazati driazati mentioned this issue Feb 18, 2022
Merged
driazati added a commit to driazati/tvm that referenced this issue Feb 18, 2022
@driazati
[ci] Disable flaky cmsisnn tests
87e37fb 
See apache#10314

cc @masahi
masahi pushed a commit that referenced this issue Feb 19, 2022
@driazati
[ci] Disable flaky cmsisnn tests (#10315)
b445d66 
See #10314

cc @masahi

Co-authored-by: driazati <driazati@users.noreply.github.com>
This was referenced Feb 28, 2022
Merged
Merged
lhutton1 added a commit to lhutton1/tvm that referenced this issue Mar 7, 2022
@lhutton1
[AOT] Use python temporary directory for AOT tests
e12d6ba 
Uses a python temporary directory with a context manager in an effort to
solve the flaky FVP tests raised in
apache#10300 and
apache#10314. Now that CI is becoming
more and more parallelized, the thinking is that the python temporary
directory implementation might be more stable than `utils.tempdir`.
Removing the XFail markings off the affected tests, but keeping the
work around implemented in apache#10408
while we monitor with the above change.

Change-Id: Id07869b51cd2278ec4885ef964bc1b23892ba235
@lhutton1 lhutton1 mentioned this issue Mar 7, 2022
Merged
lhutton1 added a commit to lhutton1/tvm that referenced this issue Mar 8, 2022
@lhutton1
[AOT] Use python temporary directory for AOT tests
f818aa5 
Uses a python temporary directory with a context manager in an effort to
solve the flaky FVP tests raised in
apache#10300 and
apache#10314. Now that CI is becoming
more and more parallelized, the thinking is that the python temporary
directory implementation might be more stable than `utils.tempdir`.
Removing the XFail markings off the affected tests, but keeping the
work around implemented in apache#10408
while we monitor with the above change.

Change-Id: Id07869b51cd2278ec4885ef964bc1b23892ba235
manupak pushed a commit that referenced this issue Mar 10, 2022
@lhutton1
[AOT] Use python temporary directory for AOT tests (#10518)
39bf923 
* [AOT] Use python temporary directory for AOT tests

Uses a python temporary directory with a context manager in an effort to
solve the flaky FVP tests raised in
#10300 and
#10314. Now that CI is becoming
more and more parallelized, the thinking is that the python temporary
directory implementation might be more stable than `utils.tempdir`.
Removing the XFail markings off the affected tests, but keeping the
work around implemented in #10408
while we monitor with the above change.

Change-Id: Id07869b51cd2278ec4885ef964bc1b23892ba235

* alter context manager to make more readable

Change-Id: Iba0644db14e50648f6dc99a4ed0f455641c31912
pfk-beta pushed a commit to pfk-beta/tvm that referenced this issue Apr 11, 2022
@driazati
[ci] Disable flaky cmsisnn tests (apache#10315)
d03ed61 
See apache#10314

cc @masahi

Co-authored-by: driazati <driazati@users.noreply.github.com>
pfk-beta pushed a commit to pfk-beta/tvm that referenced this issue Apr 11, 2022
@lhutton1
[AOT] Use python temporary directory for AOT tests (apache#10518)
6dd9c76 
* [AOT] Use python temporary directory for AOT tests

Uses a python temporary directory with a context manager in an effort to
solve the flaky FVP tests raised in
apache#10300 and
apache#10314. Now that CI is becoming
more and more parallelized, the thinking is that the python temporary
directory implementation might be more stable than `utils.tempdir`.
Removing the XFail markings off the affected tests, but keeping the
work around implemented in apache#10408
while we monitor with the above change.

Change-Id: Id07869b51cd2278ec4885ef964bc1b23892ba235

* alter context manager to make more readable

Change-Id: Iba0644db14e50648f6dc99a4ed0f455641c31912
@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
lhutton1 added a commit to lhutton1/tvm that referenced this issue Jun 29, 2023
@lhutton1
[AOT] Remove workaround to help resolve test flakyness
063afb8 
Now that apache#10300 and apache#10314 have been closed, we should be able to
remove an old previous attempt to help resolve test flakyness.

Change-Id: I70c09d6ba5ffc5cb15d0b775732bd048b7ebfbb4
@lhutton1 lhutton1 mentioned this issue Jun 29, 2023
Merged
lhutton1 added a commit to lhutton1/tvm that referenced this issue Jun 29, 2023
@lhutton1
[AOT] Remove workaround to help resolve test flakiness
ea6245f 
Now that apache#10300 and apache#10314 have been closed, we should be able to
remove an old previous attempt to help resolve test flakiness.

Change-Id: I70c09d6ba5ffc5cb15d0b775732bd048b7ebfbb4
lhutton1 added a commit that referenced this issue Jul 3, 2023
@lhutton1
[AOT] Remove workaround to help resolve test flakiness (#15181)
f14c61f 
Now that #10300 and #10314 have been closed, we should be able to
remove an old previous attempt to help resolve test flakiness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it test: flaky
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@areusch @driazati