Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error Golang 1.11 (go1.11.4 darwin) #2517

Closed
patrikhermansson opened this issue Jan 28, 2019 · 2 comments
Closed

Compilation error Golang 1.11 (go1.11.4 darwin) #2517

patrikhermansson opened this issue Jan 28, 2019 · 2 comments
Assignees

Comments

@patrikhermansson
Copy link

patrikhermansson commented Jan 28, 2019

Hi,
I'm getting the following error when building the Golang module. Latest checkout of the tvm repository.

go version go1.11.4 darwin/amd64

`$ make
function_test.go:207:30: error strings should not be capitalized or end with punctuation or a newline
ndarray.go:104:30: error strings should not be capitalized or end with punctuation or a newline
ndarray.go:198:30: error strings should not be capitalized or end with punctuation or a newline
ndarray.go:282:26: error strings should not be capitalized or end with punctuation or a newline
ndarray.go:293:34: error strings should not be capitalized or end with punctuation or a newline
value.go:310:34: error strings should not be capitalized or end with punctuation or a newline
value.go:323:30: error strings should not be capitalized or end with punctuation or a newline

gotvm

./ndarray.go:251: cannot use (*_Ctype_long)(&shape[0]) (type *_Ctype_long) as type *_Ctype_longlong in argument to func literal
make: *** [all] Error `

@srkreddy1238
Copy link
Contributor

@patrikhermansson thanks for reporting, let me check.

@srkreddy1238 srkreddy1238 self-assigned this Jan 29, 2019
srkreddy1238 added a commit to srkreddy1238/tvm that referenced this issue Feb 4, 2019
@srkreddy1238
Copy link
Contributor

@patrikhermansson can you try below patch ?

diff --git a/golang/Makefile b/golang/Makefile
index 54019740..d62133b7 100644
--- a/golang/Makefile
+++ b/golang/Makefile
@@ -7,8 +7,8 @@ NATIVE_SRC = tvm_runtime_pack.cc
 
 GOPATH=$(CURDIR)/gopath
 GOPATHDIR=${GOPATH}/src/${TARGET}/
-CGO_CPPFLAGS="-I. -I${TVM_BASE}/ -I${TVM_BASE}/3rdparty/dmlc-core/include -I${TVM_BASE}/include -I${TVM_BASE}/3rdparty/dlpack/include/"
-CGO_CXXFLAGS="-std=c++11"
+CGO_CPPFLAGS="-I. -I${TVM_BASE}/ -I${TVM_BASE}/3rdparty/dmlc-core/include -I${TVM_BASE}/include -I${TVM_BASE}/3rdparty/dlpack/include/ -m64"
+CGO_CXXFLAGS="-std=c++11 -m64"
 CGO_CFLAGS="-I${TVM_BASE}"
 CGO_LDFLAGS="-ldl -lm"

tqchen pushed a commit that referenced this issue Feb 6, 2019
libing4752 pushed a commit to libing4752/tvm that referenced this issue Feb 18, 2019
merrymercy pushed a commit to merrymercy/tvm that referenced this issue Feb 18, 2019
@tqchen tqchen closed this as completed Feb 18, 2019
wweic pushed a commit to neo-ai/tvm that referenced this issue Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this issue Feb 20, 2019
@yzhliu yzhliu mentioned this issue Mar 2, 2019
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants