Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][RFC] FuseOps and Tuple #2931

Closed
MarisaKirisame opened this issue Mar 30, 2019 · 2 comments
Closed

[Relay][RFC] FuseOps and Tuple #2931

MarisaKirisame opened this issue Mar 30, 2019 · 2 comments

Comments

@MarisaKirisame
Copy link
Contributor

After some consideration I think #2914 is not the best way to support tuple in fusion.
0: it could handle tuple of tuple, it is the relay interpreter that is incorrect (it didnot recursively fset, but instead assume it is either tensor or tuple of tensor).
1: it should not care about reference at all!
as operator accept recursive tuple of tensor, if there is reference in the code, it will never become a tensor (except by function call, or refget). the correct place to catch for reference, is at refget/forigen function call, and not a tensor.

@MarisaKirisame
Copy link
Contributor Author

@masahi @tqchen

@tqchen
Copy link
Member

tqchen commented Apr 17, 2019

#3039

@tqchen tqchen closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants