[Relay] Fix Fuse #3035
Merged
[Relay] Fix Fuse #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
reviewed
Apr 17, 2019
src/relay/pass/fuse_ops.cc
Outdated
| @@ -865,9 +865,17 @@ class FuseMutator : private ExprMutator { | |||
| } | |||
|
|
|||
| Expr MakeNewFunction(GraphPartitioner::Group* group, Type ret_type, Expr body) { | |||
| // If the function has no call, it is not a primitive function. | |||
| struct HasCallVisitor : ExprVisitor { | |||
| bool HasCall = false; | |||
masahi
requested changes
Apr 17, 2019
masahi
approved these changes
Apr 17, 2019
|
I believe that we will need a bit more discussion about what is happening here. In particular, the usage of fusor and primitive functions. There might be a better fix to this problem e.g. (not fuse these ops) |
|
Move discussion to #3039 |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* save * fix * Update fuse_ops.cc
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* save * fix * Update fuse_ops.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.