Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] [Error] fuse does not work on trivial usecase of tuplegetitem #3026

Closed
wants to merge 1 commit into from

Conversation

MarisaKirisame
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@MarisaKirisame
Copy link
Contributor Author

@masahi @tqchen @vinx13 do you three has any idea how to fix this?

@masahi
Copy link
Member

masahi commented Apr 15, 2019

I'll take a look.

@masahi
Copy link
Member

masahi commented Apr 16, 2019

@MarisaKirisame ok, the cause was this line. Currently, when we make a new subfusion in the fusion pass, the fused function is always "Primitive" function. For this test case, if you replace that line with

func = FunctionSetAttr(func, "Primitive", tvm::Integer(0));

it will work. Now the question is how to decide if the new fused function should be primitive or not.

@tqchen tqchen closed this Apr 16, 2019
@tqchen
Copy link
Member

tqchen commented Apr 16, 2019

@MarisaKirisame it is better to continue the discussion with a new thread on https://discuss.tvm.ai/ with a development tag

@MarisaKirisame MarisaKirisame mentioned this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants