Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELAY] Avoid eager creation of global target object #3197

Closed
tqchen opened this issue May 16, 2019 · 4 comments
Closed

[RELAY] Avoid eager creation of global target object #3197

tqchen opened this issue May 16, 2019 · 4 comments

Comments

@tqchen
Copy link
Member

tqchen commented May 16, 2019

https://github.com/dmlc/tvm/blob/master/src/relay/backend/build_module.cc#L54

Not all target is enabled.

It is usually not a good practice to eagerly create a global static object(which might have initialization order issue).

@tqchen
Copy link
Member Author

tqchen commented May 16, 2019

cc @zhiics please fix ASAP

cc @jroesch @vinx13 @wweic @hlu1

@zhiics
Copy link
Member

zhiics commented May 16, 2019

I will move them back to std::string and create when necessary.

@tqchen
Copy link
Member Author

tqchen commented May 16, 2019

#3198

@zhiics
Copy link
Member

zhiics commented May 16, 2019

@tqchen Thanks for the fix.

@tqchen tqchen closed this as completed May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants