Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Compilation] replace relay.build_module with C++ BuildModule #3174

Merged
merged 8 commits into from
May 16, 2019

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented May 10, 2019

This PR ports the relay.build_module from Python to using C++ APIs developed in #3082. Some Python codes are still needed, like AutoTVM related ones. In addition, some fp16 tests are added.

@antinucleon @jroesch @wweic @MarisaKirisame @tqchen

Copy link
Contributor

@wweic wweic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

python/tvm/relay/backend/graph_runtime_codegen.py Outdated Show resolved Hide resolved
python/tvm/relay/build_module.py Outdated Show resolved Hide resolved
python/tvm/relay/build_module.py Outdated Show resolved Hide resolved
python/tvm/relay/build_module.py Outdated Show resolved Hide resolved
src/relay/backend/build_module.cc Outdated Show resolved Hide resolved
@tqchen
Copy link
Member

tqchen commented May 13, 2019

Need a few more reviews. @jroesch can you manage this PR?

@jroesch
Copy link
Member

jroesch commented May 13, 2019

Need a few more reviews. @jroesch can you manage this PR?

Yes I can, I was waiting for everyone to take some review passes.

cc @antinucleon can you take a look as well?

EDIT: never mind I see that you approved 👍

src/relay/backend/build_module.cc Show resolved Hide resolved
src/relay/backend/build_module.cc Outdated Show resolved Hide resolved
@tqchen tqchen merged commit 0f2a308 into apache:master May 16, 2019
@tqchen
Copy link
Member

tqchen commented May 16, 2019

Thanks, @zhiics @jroesch @vinx13 @wweic @hlu1 this PR is now merged

@zhiics zhiics deleted the build_module branch May 16, 2019 00:56
@kparzysz-quic
Copy link
Contributor

This results in a runtime message: src/codegen/build_module.cc:132: Unknown target name vpi.

See https://discuss.tvm.ai/t/unknown-target-name-vpi/2589.

@tqchen
Copy link
Member

tqchen commented May 16, 2019

#3197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants