Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend][MXNet] Importer Missing Operators #7186

Closed
2 of 3 tasks
sxjscience opened this issue Dec 31, 2020 · 6 comments
Closed
2 of 3 tasks

[Frontend][MXNet] Importer Missing Operators #7186

sxjscience opened this issue Dec 31, 2020 · 6 comments
Labels
frontend:mxnet python/tvm/relay/frontend/mxnet* status: help wanted

Comments

@sxjscience
Copy link
Member

sxjscience commented Dec 31, 2020 •
edited by junrushao
Loading

Feature Request

Recently, TVM has supported the incoming MXNet 2.0 frontend via a series of PRs: #6054, #6699. This enables the new GluonNLP 1.0, which has been upgraded from MXNet 1.x to MXNet 2.0 to convert to TVM graph (as added in dmlc/gluon-nlp#1390).

However, not all operators in MXNet support conversion to TVM. The following is the list of operators that need to be supported.
@sxjscience
Copy link
Member Author

@junrushao1994 I created this new issue. Also, I just figured out that I cannot attach the "help wanted" label so would you help with that?

@sxjscience sxjscience mentioned this issue Dec 31, 2020
Closed
insop added a commit to insop/incubator-tvm that referenced this issue Jan 3, 2021
@insop
[Frontend][MXNet] add _npi_subtract_scalar
426e048 
- add mxnet numpy operator, subtract
- apache#7186
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.subtract.html
@insop insop mentioned this issue Jan 3, 2021
Merged
@insop
Copy link
Contributor

insop commented Jan 3, 2021

For _npi_subtract_scalar BART model: #7191 is submitted.

masahi pushed a commit that referenced this issue Jan 3, 2021
@insop
[Frontend][MXNet] add _npi_subtract_scalar (#7191)
86a8504 
* [Frontend][MXNet] add _npi_subtract_scalar

- add mxnet numpy operator, subtract
- #7186
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.subtract.html

* Fix python style using black
insop added a commit to insop/incubator-tvm that referenced this issue Jan 5, 2021
@insop
[Frontend][MXNet] add _npi_stack, issue apache#7186
faeebb0 
- apache#7186
- add MxNet stack, `_npi_stack`
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack
@insop insop mentioned this issue Jan 5, 2021
Merged
@insop
Copy link
Contributor

insop commented Jan 5, 2021

For _npi_stack : #7209 is submitted.

junrushao pushed a commit that referenced this issue Jan 6, 2021
@insop
[Frontend][MXNet] add _npi_stack, issue #7186 (#7209)
3f0dc42 
- #7186
- add MxNet stack, `_npi_stack`
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack
@insop insop mentioned this issue Jan 8, 2021
Closed
@insop
Copy link
Contributor

insop commented Jan 8, 2021

For _npi_advanced_indexing_multiple is at #7230 (review), PTAL.

@sxjscience
Copy link
Member Author

Also, there is another issue that I observed in GluonNLP: dmlc/gluon-nlp#1425 . The initial investigation suggests it's related to mixed-dtype support in the MXNet --> TVM converter.

@insop
Copy link
Contributor

insop commented Jan 10, 2021

For _npi_advanced_indexing_multiple is at #7230 (review), PTAL.

@sxjscience
Any help on the above PR will be appreciated.
Thank you.

tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this issue Jan 11, 2021
@insop @tkonolige
[Frontend][MXNet] add _npi_subtract_scalar (apache#7191)
c5c8145 
* [Frontend][MXNet] add _npi_subtract_scalar

- add mxnet numpy operator, subtract
- apache#7186
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.subtract.html

* Fix python style using black
tkonolige pushed a commit to tkonolige/incubator-tvm that referenced this issue Jan 11, 2021
@insop @tkonolige
[Frontend][MXNet] add _npi_stack, issue apache#7186 (apache#7209)
d0cf5a5 
- apache#7186
- add MxNet stack, `_npi_stack`
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack
masahi pushed a commit to masahi/tvm that referenced this issue Jan 14, 2021
@insop @masahi
[Frontend][MXNet] add _npi_stack, issue apache#7186 (apache#7209)
6b17758 
- apache#7186
- add MxNet stack, `_npi_stack`
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this issue Jan 20, 2021
@insop
[Frontend][MXNet] add _npi_subtract_scalar (apache#7191)
160c97d 
* [Frontend][MXNet] add _npi_subtract_scalar

- add mxnet numpy operator, subtract
- apache#7186
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.subtract.html

* Fix python style using black
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this issue Jan 20, 2021
@insop
[Frontend][MXNet] add _npi_stack, issue apache#7186 (apache#7209)
31bdbeb 
- apache#7186
- add MxNet stack, `_npi_stack`
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack
trevor-m pushed a commit to neo-ai/tvm that referenced this issue Jan 21, 2021
@insop @trevor-m
[Frontend][MXNet] add _npi_subtract_scalar (apache#7191)
9bf53e7 
* [Frontend][MXNet] add _npi_subtract_scalar

- add mxnet numpy operator, subtract
- apache#7186
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.subtract.html

* Fix python style using black
trevor-m pushed a commit to neo-ai/tvm that referenced this issue Jan 21, 2021
@insop @trevor-m
[Frontend][MXNet] add _npi_stack, issue apache#7186 (apache#7209)
189929a 
- apache#7186
- add MxNet stack, `_npi_stack`
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack
electriclilies pushed a commit to electriclilies/tvm that referenced this issue Feb 18, 2021
@insop @electriclilies
[Frontend][MXNet] add _npi_subtract_scalar (apache#7191)
9636553 
* [Frontend][MXNet] add _npi_subtract_scalar

- add mxnet numpy operator, subtract
- apache#7186
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.subtract.html

* Fix python style using black
electriclilies pushed a commit to electriclilies/tvm that referenced this issue Feb 18, 2021
@insop @electriclilies
[Frontend][MXNet] add _npi_stack, issue apache#7186 (apache#7209)
6f0b7c1 
- apache#7186
- add MxNet stack, `_npi_stack`
- https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack
@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@hpanda-naut hpanda-naut added frontend:mxnet python/tvm/relay/frontend/mxnet* and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Nov 28, 2022
@tqchen tqchen closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend:mxnet python/tvm/relay/frontend/mxnet* status: help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@areusch @insop @tqchen @sxjscience @junrushao @hpanda-naut