Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Skip TensorCore TOPI test when it is not available #7277

Closed
tqchen opened this issue Jan 13, 2021 · 4 comments
Closed

[TEST] Skip TensorCore TOPI test when it is not available #7277

tqchen opened this issue Jan 13, 2021 · 4 comments

Comments

@tqchen
Copy link
Member

tqchen commented Jan 13, 2021

#7146 Introduces a test on tensorcore for batchmatmul

Because tensorcore is only optionally supported in the topi testing stage, it would be great to skip it when it is not available.

@tqchen
Copy link
Member Author

tqchen commented Jan 13, 2021

cc @jwfromm @jcf94 @Meteorix

@leandron
Copy link
Contributor

leandron commented Jan 15, 2021

(Posting here as I think it is related)

When running TVM tests on a CPU only machine, I'm getting an error when running /test_topi_batch_matmul_tensorcore.py:test_batch_matmul:

@tvm.testing.uses_gpu
def test_batch_matmul():
verify_batch_matmul(1, 1, 16, 16, 32)
verify_batch_matmul(5, 5, 16, 16, 32)
verify_batch_matmul(5, 5, 16, 32, 32)
verify_batch_matmul(30, 30, 16, 32, 32)

The error I see is:

Check failed: allow_missing == false: Device API gpu is not enabled.

As you can see, the test is marked as uses_gpu.

I wonder whether we should move it to either requires_gpu or even requires_tensorcore? (happy to send a PR, in either case)

@tqchen
Copy link
Member Author

tqchen commented Jan 15, 2021

I think requires_tensorcore is the right macro cc @tkonolige

@tkonolige
Copy link
Contributor

Yes, it should be requires_tensorcore.

tqchen pushed a commit that referenced this issue Jan 16, 2021
…uirement (#7294)

* this test current sets a requirement to "uses_gpu", which
   causes it to fail in cpu-only machine
 * this patch changes it to be "requires_tensorcore", as per discussion
   on issue #7277
@tqchen tqchen closed this as completed Jan 16, 2021
masahi pushed a commit to masahi/tvm that referenced this issue Jan 18, 2021
…uirement (apache#7294)

* this test current sets a requirement to "uses_gpu", which
   causes it to fail in cpu-only machine
 * this patch changes it to be "requires_tensorcore", as per discussion
   on issue apache#7277
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this issue Jan 20, 2021
…uirement (apache#7294)

* this test current sets a requirement to "uses_gpu", which
   causes it to fail in cpu-only machine
 * this patch changes it to be "requires_tensorcore", as per discussion
   on issue apache#7277
trevor-m pushed a commit to neo-ai/tvm that referenced this issue Jan 21, 2021
…uirement (apache#7294)

* this test current sets a requirement to "uses_gpu", which
   causes it to fail in cpu-only machine
 * this patch changes it to be "requires_tensorcore", as per discussion
   on issue apache#7277
electriclilies pushed a commit to electriclilies/tvm that referenced this issue Feb 18, 2021
…uirement (apache#7294)

* this test current sets a requirement to "uses_gpu", which
   causes it to fail in cpu-only machine
 * this patch changes it to be "requires_tensorcore", as per discussion
   on issue apache#7277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants