-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] skip non-docs phases when a PR only modifies docs/
#8673
Comments
Thanks for bringing this up! I was thinking about this issue while ago but didn't take actions... |
I think if it possible to move the CI to GH actions only for doc changes, it will remove a lot of overhead from the current Jenkins workers. |
@comaniac Ah I should have said changes in The main question is whether we can reliably reproduce the results of the CI on GH actions. Since the underlying machine will vary, and tutorials are executed as TVM code during the docs build, I favor to keep everything centralized (otherwise tutorials might output different results than you see on CI). On the other hand, I understand that if we're just limiting to |
Oops I missed the tutorials. Yeah compiling tutorials requires specific machines, so we probably still need to use the Jenkins CI. |
the tricky thing is that we still do want to run some CI tasks--we just want to skip most of them. for example, you could checkin broken ReStructuredText--we should still fail the CI if you try to do this. So I think we do need to modify the Jenkinsfile. |
Right now it's really difficult to write docs because you're subjected to the standard 5-10 hour CI flow. This is completely unnecessary when just changing the docs site--we only need to do a GPU-aware build of TVM, then run the docs stage. docs depends on tutorials, which are executed against the GPU node.
my thinking is:
docs
(e.g.git diff --name-only HEAD...origin/main
or something like it (think Jenkins will have merged the PR into local main at this point)). Set a Jenkinsfile var based on this@mikepapadim will take a look at this
cc @leandron @denise-k
The text was updated successfully, but these errors were encountered: