-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent non-docs stages when a PR only modifies docs/ #8992
Conversation
Thanks, @mikepapadim. I agree that it is important to save the CI time. However, tutorials may be changed even though the codes in |
@mikepapadim this looks much closer to what we want but I think if I'm reading this right, I see:
as @Hzfengsy said, we shouldn't ever skip these nodes:
i think we need to find a way to propagate these conditions down to the node level in each stage (e.g. skip each node not listed above when |
Yes, right now the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple unrelated changes to this patch. Apart from that, I agree in principle with the proposed change.
@@ -6,9 +6,9 @@ | |||
# to you under the Apache License, Version 2.0 (the | |||
# "License"); you may not use this file except in compliance | |||
# with the License. You may obtain a copy of the License at | |||
# | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an unrelated change.
@@ -19,4 +19,3 @@ Include the title of the document (e.g. "Getting Started with TVM"), and the typ | |||
If an RFC/discuss post exists, link it here. | |||
|
|||
Otherwise, specify what actions should be taken to provide additional clarity/readability/reproducibility to the document. Include code snippets from the previous documentation if applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an unrelated change.
This is an intermediate fix for #8673.
It modifies
Jenkinsfile
to prevent non-doc related stages from running when only modifying indocs/
.The idea is to save some CI cycles and speed up the process of augmenting docs.
@areusch @comaniac @tqchen