Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Revert "[AUTOTVM] Use opt level 3 when extracting tasks" #10171

Closed

Conversation

anwang2009
Copy link
Contributor

Reverts #10065.

After doing a sweep on nvidia t4 with 2000 autotvm trials, I'm seeing regressions across the board as compared to before this commit. We should revert and investigate why this is happening before we enable this change broadly

image

@anwang2009
Copy link
Contributor Author

cc @tkonolige @masahi

@masahi
Copy link
Member

masahi commented Feb 4, 2022

I dont like reverting this. This will put us back to the wrong state and there is no guarentee that it will be restored later unless someone takes an action.

So instead of reverting this to workaround the immediate perf problem, can we pursue a more long term solution. Have you tried enabling alter layout? If this is cuda, the issue is most likely related to winograd.

@anwang2009
Copy link
Contributor Author

Yeah, we've tried enabling alter layout. It has similar results as shown. I'm seeing regressions on broadwell as well as nvidia tesla t4, but the regressions are more pronounced on the t4. Currently running a sweep to confirm if the problem was actually this PR or another one on the stack.

@AndrewZhaoLuo
Copy link
Contributor

@anwang2009 can you open an issue for tracking and then maybe we will be amenable to merging?

@anwang2009 anwang2009 changed the title Revert "[AUTOTVM] Use opt level 3 when extracting tasks" [DO NOT MERGE] Revert "[AUTOTVM] Use opt level 3 when extracting tasks" Feb 7, 2022
@anwang2009
Copy link
Contributor Author

Awaiting results of this sweep before further action

@anwang2009
Copy link
Contributor Author

Closing this. Sweeps show that the relay opt level 3 is the right approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants