Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CODEOWNERS #10192

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Remove CODEOWNERS #10192

merged 1 commit into from
Mar 11, 2022

Conversation

driazati
Copy link
Member

@driazati driazati commented Feb 8, 2022

@jroesch
Copy link
Member

jroesch commented Feb 8, 2022

cc @driazati @tqchen would it better to disable this mechanism instead of removing/moving the file?

@Mousius
Copy link
Member

Mousius commented Feb 9, 2022

Another option is to break down the various areas so a small change won't ping everyone? Currently it's very broad, and doing a bit of a folder structure clean up may help as the codebase has evolved a bit?

@driazati
Copy link
Member Author

cc @driazati @tqchen would it better to disable this mechanism instead of removing/moving the file?

That would be nice but AFAIK GitHub doesn't have any setting for it so we're stuck with something like this if we want to keep this information around

Another option is to break down the various areas so a small change won't ping everyone? Currently it's very broad, and doing a bit of a folder structure clean up may help as the codebase has evolved a bit?

@Mousius sorry for the delay, but see the pre-RFC in https://discuss.tvm.apache.org/t/rfc-remove-codeowners/12095, it has a section on this

@driazati driazati marked this pull request as ready for review March 10, 2022 21:52
@driazati
Copy link
Member Author

#10471 is closed in favor, this is ready to merge! @areusch

See RFC: <link tbd>
@driazati
Copy link
Member Author

See followups in #10575

@masahi masahi merged commit 0b37bd2 into apache:main Mar 11, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
See RFC: <link tbd>

Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants