Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Follow up fixes on PR #9631 #10205

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Feb 9, 2022

Follow up fixes on hexagon RPC server.

@mehrdadh
Copy link
Member Author

mehrdadh commented Feb 9, 2022

cc @kparzysz-quic

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mehrdadh

@kparzysz-quic
Copy link
Contributor

kparzysz-quic commented Feb 11, 2022

In src/runtime/hexagon/rpc/hexagon/rpc_server.cc, line 198, you don't need to use new. You can statically allocate a local array (i.e. static uint8_t buffer[...]) and pass it to the server.

Copy link
Contributor

@kparzysz-quic kparzysz-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nitpick. It can be addressed later.

@kparzysz-quic kparzysz-quic merged commit c20cbc5 into apache:main Feb 11, 2022
@mehrdadh mehrdadh deleted the hexagon/fix_rpc_server_issues branch February 14, 2022 17:48
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants