[CMSIS-NN] enable USMP with CMSIS-NN #10224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manupak
requested review from
zhiics,
trevor-m,
comaniac,
mbaret,
jroesch,
slyubomirsky,
icemelon,
MarisaKirisame,
ZihengJiang,
yzhliu,
vinx13,
mbrookhart,
jwfromm,
anijain2305,
wweic,
junrushao,
areusch,
liangfu,
tmoreau89,
tqchen,
kparzysz-quic,
masahi,
Hzfengsy and
merrymercy
as code owners
|
cc : @ashutosh-arm @Mousius |
manupak
force-pushed
the
cmsisnn_usmp
branch
3 times, most recently
from
a12bea9 to
dda2bf2
Compare
manupak
force-pushed
the
cmsisnn_usmp
branch
2 times, most recently
from
061dfc4 to
130f22d
Compare
|
This is ready for review. @ashutosh-arm @Mousius |
manupak
force-pushed
the
cmsisnn_usmp
branch
from
130f22d to
8c711d9
Compare
|
Friendly ping for reviews! @ekalda @lhutton1 @ashutosh-arm @leandron |
lhutton1
reviewed
Feb 28, 2022
| @@ -27,6 +27,7 @@ | |||
| from tests.python.relay.aot.aot_test_utils import ( | |||
| AOTTestModel, | |||
| AOT_CORSTONE300_RUNNER, | |||
There was a problem hiding this comment.
Nit: unused import? (elsewhere as well)
There was a problem hiding this comment.
Thanks @manupa-arm . Overall looks good to me :) Few minor comments.
This commit mainly enables the USMP with CMSIS-NN codegen. In order to do that, CMSIS-NN functions needed to contain BufferMaps. This commit adds the necessary BufferMaps as well. All the tests are modified to run with USMP while the networks tests run with and without USMP. Change-Id: I18c7958addfff90b8243e9a6c70b7411158462fa
"NULL" should be supplied as an extern arg if the context buffer is not allocated. Change-Id: I58866df69a27ce976ac45a57e2f261094a48e48e
* renaming buffer_var to be context_buffer_var * removing trailing underscore from local variable : buffer_creator Change-Id: I874164aa4944087c0e13cef80ead04c0de2be149
|
@ashutosh-arm, I've addressed the comments, PTAL when you have some time! |
|
Thanks @manupa-arm. I suppose it was already in a good state to be merged :) |
|
No worries, nothing major :) |
Mousius
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Thanks for the reviews @ashutosh-arm / @lhutton1 - makes sense to me 😸
|
Thanks @manupa-arm! |
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
This commit mainly enables the USMP with CMSIS-NN codegen. In order to do that, CMSIS-NN functions needed to contain BufferMaps. This commit adds the necessary BufferMaps as well. All the tests are modified to run with USMP while the networks tests run with and without USMP.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This commit mainly enables the USMP with CMSIS-NN codegen. In order to do that, CMSIS-NN functions needed to contain BufferMaps. This commit adds the necessary BufferMaps as well. All the tests are modified to run with USMP while the networks tests run with and without USMP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mainly enables the USMP with CMSIS-NN codegen.
In order to do that, CMSIS-NN functions needed to contain BufferMaps. This commit adds the necessary BufferMaps as well.
All the tests are modified to run with USMP while the networks tests run with and without USMP.