-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] Refactor Hexagon.cmake #10227
[Hexagon] Refactor Hexagon.cmake #10227
Conversation
I think we can drop tvm/cmake/modules/HexagonSDK.cmake Lines 85 to 104 in 220b122
since I don't think we support SDK v3 anymore. |
This file is included every time TVM is build, regardless of whether any support for Hexagon is enabled or not. This refactoring is meant to remove underlying assumptions about what features are enabled and what the compilation targets are. Now, when there is nothing needed from Hexagon, the script exits early (although it doesn't need to), and the rest of it is (and should remain) safe to execute regardless of build configuration. Disable "runtime.module.loadfile_hexagon" from the offload runtime, since it conflicts with device_api.hexagon.v2. It was only used with offload on Android, which is being deprecated.
I think that v65 and v66 should still work, and you'd need SDK 3.x for v65. Having said that, I'm ok with dropping SDK 3.x, but I ask around before doing that. I rebased the current commit as it is. If we decide to drop 3.x, we could probably do it in another commit (since it's in a different .cmake file). |
This file is included every time TVM is build, regardless of whether any support for Hexagon is enabled or not. This refactoring is meant to remove underlying assumptions about what features are enabled and what the compilation targets are. Now, when there is nothing needed from Hexagon, the script exits early (although it doesn't need to), and the rest of it is (and should remain) safe to execute regardless of build configuration. Disable "runtime.module.loadfile_hexagon" from the offload runtime, since it conflicts with device_api.hexagon.v2. It was only used with offload on Android, which is being deprecated.
This file is included every time TVM is build, regardless of whether any support for Hexagon is enabled or not. This refactoring is meant to remove underlying assumptions about what features are enabled and what the compilation targets are. Now, when there is nothing needed from Hexagon, the script exits early (although it doesn't need to), and the rest of it is (and should remain) safe to execute regardless of build configuration. Disable "runtime.module.loadfile_hexagon" from the offload runtime, since it conflicts with device_api.hexagon.v2. It was only used with offload on Android, which is being deprecated.
This file is included every time TVM is build, regardless of whether any support for Hexagon is enabled or not. This refactoring is meant to remove underlying assumptions about what features are enabled and what the compilation targets are. Now, when there is nothing needed from Hexagon, the script exits early (although it doesn't need to), and the rest of it is (and should remain) safe to execute regardless of build configuration.
Disable "runtime.module.loadfile_hexagon" from the offload runtime, since it conflicts with device_api.hexagon.v2. It was only used with offload on Android, which is being deprecated.