Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RPC waiting for device #10255

Merged
merged 1 commit into from
Feb 16, 2022
Merged

fix RPC waiting for device #10255

merged 1 commit into from
Feb 16, 2022

Conversation

pfk-beta
Copy link
Contributor

Hello,
This PR solves issue 10240. Previous implementation for checking device was little misleading/problematic. It was checking device in almost infinite loop (while not dev.exist), but the thread which was doing this was set with timeout. Check status was equivalent to thread state, imho it's incorrect and misleading.

So I have changed to more proper way, but with little duplicated code:

  1. Still we have almost infinite loop (while not dev.exist)
  2. After loop finish we do not check thread status, but again check device
  3. I have added extra debug logging - leave or remove it - decision for owners of the project :)

@pfk-beta
Copy link
Contributor Author

Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@masahi masahi merged commit 75122db into apache:main Feb 16, 2022
pfk-beta added a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
Co-authored-by: pfk-beta <this_email_isnot_working@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants