[runtime] Add Metadata classes for AOTExecutor #10282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
requested review from
vinx13,
tqchen,
liangfu,
tmoreau89,
masahi,
kazum,
ZihengJiang,
junrushao,
kparzysz-quic,
comaniac,
jroesch,
yzhliu,
merrymercy,
icemelon and
zhiics
as code owners
5 tasks
areusch
force-pushed
the
aot-mbmr-metadata
branch
from
c6022d6 to
2f64ab0
Compare
* These were autogenerated in the original PR, but checking them in as plain code until we can revisit the auto-generator approach.
areusch
force-pushed
the
aot-mbmr-metadata
branch
from
2f64ab0 to
4d3d047
Compare
masahi
reviewed
Feb 18, 2022
masahi
reviewed
Feb 18, 2022
masahi
approved these changes
Feb 21, 2022
manupak
reviewed
Feb 21, 2022
| } | ||
| }; | ||
|
|
||
| class InMemoryMetadataNode : public ::tvm::target::metadata::VisitableMetadataNode { |
There was a problem hiding this comment.
Can you provide more explanation for the variants of InMemory* ? Also the reasons for needing a seperate object for that as opposed to having a constructor for MetadataNode
areusch
commented
Feb 22, 2022
There was a problem hiding this comment.
@manupa-arm I added a bunch of docs, PTAL when you get a minute!
| } | ||
| }; | ||
|
|
||
| class InMemoryMetadataNode : public ::tvm::target::metadata::VisitableMetadataNode { |
|
Thank you @manupa-arm and @areusch ! This PR has been merged. |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* Add new Metadata classes and base implementation. * These were autogenerated in the original PR, but checking them in as plain code until we can revisit the auto-generator approach. * address masa comments * Add documentation per Manupa's comments, and move kMetadataVersion namespace. * remove get_name function, used for debugging * clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Metadata classes to hold model metadata needed to implement a Module-based Model Runtime interface for AOT. These Metadata implementations are distinct from others in the codebase in that all of the backing data can exist in C as const struct (meaning that on small targets, it can live along with the code in e.g. flash memory).
TODO: add test to verify that metadata.h compiles from a C compiler.
cc @Mousius @manupa-arm @kparzysz-quic @masahi @mehrdadh