-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tir.constant] bugfix 10390 #10465
[tir.constant] bugfix 10390 #10465
Conversation
cc @manupa-arm |
cc : @kparzysz-quic |
We still get a crash with this PR, but I haven't had time to see why. |
In the FoldConstants ? |
Here's the stack trace (sorry for a wall of text). I'll investigate this further---thanks for working on the fix!
|
ok... from a high-level glance it seems it has gone beyond OptimizeImpl (which runs FoldConstants), my initial read of this says this is unrelated to #10390 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crash was because of not setting relay.FuseOps.link_params = 0
.
Could you rebase this PR? Is this the final version? |
…link-params=0 Addressed issue apache#10390 Change-Id: I1a6b2dd27845f9292f1e07f9da1b9be722481f46
…link-params=0 (apache#10465) Addressed issue apache#10390 Change-Id: I1a6b2dd27845f9292f1e07f9da1b9be722481f46
Interpreter call in FoldConstant now always uses graph executor with link-params=0
Addressed issue #10390