-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TE] Promote substituted variable to iter_var's dtype #10571
Conversation
This fixes a bug where an iteration variable and its associated loop variable have a mismatched dtype.
This problem is a lot more complicated than I initially thought. It is actually two problems: 1. |
Interesting, does this change remove the need for fixes in the following PRs? I've been trying to compile the QAT BERT from mlperf via various ways but I consistently get the int32 vs int64 dtype mismatch like:
|
I think it may fix the middle and top issues, but I'm not positive. Also, we should think about checking that every |
just sent a PR fixing a related problem (one of my errors above) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junrushao1994 @masahi Any concerns with this?
* [TE] Promote substituted variable to iter_var's dtype This fixes a bug where an iteration variable and its associated loop variable have a mismatched dtype. * add check to iter var constructor. fix two bad uses * proplem is more complicated then I thought * one more fix * remove old comments
This fixes a bug where an iteration variable and its associated loop variable have a mismatched dtype.
@mbrookhart @junrushao1994