-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] update oneDNN to v2.6 #11140
[CI] update oneDNN to v2.6 #11140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI tests your changes automatically so no worries there, I would prefer that we just upgrade the oneDNN version manually (and keep the version pinned) though instead of grabbing the latest (imagine that there is a breaking update, the Docker image build would just stop working one day)
Thanks for your comments and suggestions. I had modified the script to pin oneDNN to the latest release v2.6, and it's easy to change the pinned version or set to build the latest release. |
The CI failed due to
Should I do something or just ignore this? |
@yangulei i think this means the CI's quota to PyPI was exceeded. perhaps retry now that it's been a while? |
Yeah that index was down for a while last week (#11156 (comment)) but it should be working now. If this happens again we might want to look into rehosting some of those assets |
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yangulei and sorry for the delay here!
I submitted the PR to enable bfloat16 in DNNL BYOC(#11111). But the PR failed to be built due to the version of the oneDNN in CI is limited to v2.2, which is a relative old one. So I update the CI script to get and build the latest oneDNN release.
I had tested the script on my own PC and it works fine, but I don't know how to test the script in CI environment. So let me know if I did something inappropriate, thanks!
cc @Mousius @areusch @driazati