-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix some typos. #11503
[Fix] Fix some typos. #11503
Conversation
Can you do one single commit? |
For fear that when all the changes are submitted together, all the changes will be terminated because the CI/CD of a certain change does not pass. And considering that some open source repositories recommend separate PRs when there are many files to be modified, I submitted PRs separately. |
Yeah, please merge them into a single PR. |
OK, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quiet curious: how did you find out all those typos? This is super cool |
Maybe you can see my repo (Search-for-Typos) for details. |
This is quite cool!! Thanks @Yulv-git for sharing! |
looks like this PR cannot pass CI due to some changes in CI files. @driazati would you mind helping this PR pass? Would be super helpful to have PRs like this |
Re-ran the job, hopefully it runs all the way through this time (the Docker image builds are pretty flaky since they have to download a bunch of stuff from the internet) |
still failed :-( |
hey @Yulv-git thanks for persisting with this, could you run |
Sorry, I cannot run |
looks like we have permission to update your fork branch, I can handle shepherding this through CI in that case |
Thanks for your help. |
merged! thanks for your patience @Yulv-git |
Fix some typos in src/. Co-authored-by: driazati <driazati@users.noreply.github.com>
Fix some typos in src/.