Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix some typos. #11503

Merged
merged 7 commits into from
Aug 19, 2022
Merged

[Fix] Fix some typos. #11503

merged 7 commits into from
Aug 19, 2022

Conversation

Yulv-git
Copy link
Contributor

Fix some typos in src/.

@MarisaKirisame
Copy link
Contributor

Can you do one single commit?

@Yulv-git
Copy link
Contributor Author

Yulv-git commented May 28, 2022

Can you do one single commit?

For fear that when all the changes are submitted together, all the changes will be terminated because the CI/CD of a certain change does not pass. And considering that some open source repositories recommend separate PRs when there are many files to be modified, I submitted PRs separately.
If I need to put all the changes into one PR, I will merge them later.

@masahi
Copy link
Member

masahi commented May 28, 2022

Yeah, please merge them into a single PR.

@Yulv-git
Copy link
Contributor Author

Yeah, please merge them into a single PR.

OK, thanks!

Copy link
Contributor

@MarisaKirisame MarisaKirisame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
Copy link
Member

Quiet curious: how did you find out all those typos? This is super cool

@Yulv-git
Copy link
Contributor Author

Yulv-git commented Jun 5, 2022

Quiet curious: how did you find out all those typos? This is super cool

Maybe you can see my repo (Search-for-Typos) for details.

@junrushao
Copy link
Member

This is quite cool!! Thanks @Yulv-git for sharing!

@junrushao
Copy link
Member

looks like this PR cannot pass CI due to some changes in CI files. @driazati would you mind helping this PR pass? Would be super helpful to have PRs like this

@driazati
Copy link
Member

driazati commented Jun 7, 2022

Re-ran the job, hopefully it runs all the way through this time (the Docker image builds are pretty flaky since they have to download a bunch of stuff from the internet)

@junrushao
Copy link
Member

still failed :-(

@driazati
Copy link
Member

hey @Yulv-git thanks for persisting with this, could you run black tests/python/frontend/onnx/test_forward.py to fix the lint error?

@Yulv-git
Copy link
Contributor Author

hey @Yulv-git thanks for persisting with this, could you run black tests/python/frontend/onnx/test_forward.py to fix the lint error?

Sorry, I cannot run black tests/python/frontend/onnx/test_forward.py due to environmental problems.

@driazati
Copy link
Member

looks like we have permission to update your fork branch, I can handle shepherding this through CI in that case

@Yulv-git
Copy link
Contributor Author

looks like we have permission to update your fork branch, I can handle shepherding this through CI in that case

Thanks for your help.

@Yulv-git Yulv-git changed the title [Fix] Fix some typos in src/. [Fix] Fix some typos. Aug 18, 2022
@driazati driazati merged commit bdcfa01 into apache:main Aug 19, 2022
@driazati
Copy link
Member

merged! thanks for your patience @Yulv-git

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Fix some typos in src/.

Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants