Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Add schedule primitive ReIndex #11515

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented May 31, 2022

This PR adds a schedule primitive Reindex. It is similar to cache_read / cache_write, but it changes the buffer shape w.r.t to block iters. This makes the subsequent buffer access become contiguous access to the intermediate (reindex) buffer.

cc @spectrometerHBH @junrushao1994 @Hzfengsy

@vinx13 vinx13 force-pushed the feat/reindex branch 3 times, most recently from a407489 to 6d48a37 Compare May 31, 2022 23:03
@masahi
Copy link
Member

masahi commented Jun 1, 2022

Is this similar or equivalent to using cache_read followed by transform_layout with some index map (transpose etc)?

@vinx13
Copy link
Member Author

vinx13 commented Jun 1, 2022

It is similar to cache_read or cache_write + transform_layout but not equivalent (mainly in the way of dealing with block iters and loops)

@junrushao
Copy link
Member

CC: @spectrometerHBH would you mind reviewing this PR? Thanks a lot!

@vinx13 vinx13 merged commit 12a0f3e into apache:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants