-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Redirect sphinx-gallery URLs to S3 #11839
Conversation
a56f818
to
334417c
Compare
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in #11839
f7675cf
to
5aa13b2
Compare
79dbb9f
to
72a8b4c
Compare
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of this PR! Thanks for the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @driazati
python/tvm/testing/utils.py
Outdated
msg += f"no file\n" | ||
|
||
if base is None: | ||
hook_script_dir = Path.cwd().resovle() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
raise RuntimeError(f"Directory {hook_script_dir} does not exist:\n{msg}") | ||
|
||
# Import the hook and start it up (it's not included here directly to avoid | ||
# keeping a database of URLs inside the tvm Python package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just make the database into a datafile? e.g. load from JSON or ast.literal_eval()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems like the complexity is the same as this method (i.e. find a file, load it up) but more limited in functionality. I updated the list to de-duplicate the S3 bucket name to make it clearer the use of keeping it all Python
2bb627a
to
1d2936d
Compare
8d178c5
to
6377c7e
Compare
This follows on apache#11839 to apply it outside of docs and to tests running under pytest instead
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
Co-authored-by: driazati <driazati@users.noreply.github.com>
This follows on #11839 to apply it outside of docs and to tests running under pytest instead Co-authored-by: driazati <driazati@users.noreply.github.com>
Co-authored-by: driazati <driazati@users.noreply.github.com>
This follows on apache#11839 to apply it outside of docs and to tests running under pytest instead Co-authored-by: driazati <driazati@users.noreply.github.com>
This adds a `workflow_dispatch` only GitHub Action that committers can use to upload files to the CI bucket for use like in apache#11839
Co-authored-by: driazati <driazati@users.noreply.github.com>
This follows on apache#11839 to apply it outside of docs and to tests running under pytest instead Co-authored-by: driazati <driazati@users.noreply.github.com>
This hooks into
urllib
so we can redirect certain URLs used in CI to more reliable copies in S3. This method catches everything, even urls hidden inside third-party modules (likeoneflow
). This makes it so CI docs run with consistent speed and without the failures below. Items can be uploaded by any committer via this workflow. The S3 bucket is public, so users can still download the items if they want to exactly reproduce CI.Fixes #11918, fixes #11919, fixes #11811
cc @Mousius @areusch