Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] IndexMap.Inverse for unit iters #11841

Merged

Conversation

junrushao
Copy link
Member

No description provided.

@junrushao junrushao marked this pull request as ready for review June 22, 2022 23:54
Copy link
Member

@zxybazh zxybazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@junrushao junrushao merged commit 778db2f into apache:main Jun 23, 2022
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Sep 26, 2022
The two implementations were largely identical, and had
implementations that drifted apart, resulting in bugs such as
apache#12852.  This commit removes this
duplication by writing `Inverse` in terms of `NonSurjectiveInverse`.
The merged version of `NonSurjectiveInverse` contains bugfix
apache#11841, that were previously present
only in `Inverse`.
junrushao pushed a commit that referenced this pull request Sep 26, 2022
…2904)

The two implementations were largely identical, and had
implementations that drifted apart, resulting in bugs such as
#12852.  This commit removes this
duplication by writing `Inverse` in terms of `NonSurjectiveInverse`.
The merged version of `NonSurjectiveInverse` contains bugfix
#11841, that were previously present
only in `Inverse`.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…ache#12904)

The two implementations were largely identical, and had
implementations that drifted apart, resulting in bugs such as
apache#12852.  This commit removes this
duplication by writing `Inverse` in terms of `NonSurjectiveInverse`.
The merged version of `NonSurjectiveInverse` contains bugfix
apache#11841, that were previously present
only in `Inverse`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants