-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Texture] Add 2d memory support into static memory planner #11876
Conversation
@csullivan @masahi @mbs-octoml Please review and push this PR through. |
@elvin-n Can you add tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes to the graph memory planner originate back from #7690. Given that I was the author of that PR and many of these changes, I don't feel comfortable merging this without additional reviews but the change looks good to me if others feel that refactor the graph memory planner in this way is acceptable.
Ultimately in Relax graph-tir memory planning will be unified and texture can be represented as an Nd Buffer, and a separate pass can handle memory planning based on a target specific handling for Nd memory. Given that I'm personally okay with this change landing as even though it is fairly specific, we don't intend for the graph executor memory planner to be any more generically useful for Nd memory down the road.
Edit: As @masahi pointed out, it would be useful to have some unit tests of the 2d planner.
Co-authored-by: Chris Sullivan <csullivan@octoml.ai>
3cf99ab
to
9eab9b2
Compare
Added test |
Co-authored-by: Chris Sullivan csullivan@octoml.ai
This PR is a split part of origin PR11357
@csullivan @mbs-octoml