Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests #12011

Merged
merged 4 commits into from
Jul 6, 2022

Commits on Jul 5, 2022

  1. [CI] Use command-line argument or TVM_BUILD_PATH for C++ unittests

    Previously, the `ci.py` script would execute all C++ unit tests in the
    `"build"` directory, regardless of the docker image being used.  This
    change allows a caller to specify the build directory to be used by
    `task_cpp_unittest.sh`, either by the command line or by using the
    same `TVM_BUILD_PATH environment variable as used by the top-level
    Makefile, and passes this argument from `ci.py`.  To preserve the
    existing behavior for the pre-commit CI, if no argument is passed and
    if the `TVM_BUILD_PATH` is undefined, `task_cpp_unittest.sh` defaults
    to the `"build"` directory.
    
    Python unit tests executed through `ci.py` used the `TVM_LIBRARY_PATH`
    environment variable, and were not similarly affected.
    Lunderberg committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    79ec8fd View commit details
    Browse the repository at this point in the history
  2. Remove name=name in format script

    Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
    Lunderberg and driazati authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    fb35c46 View commit details
    Browse the repository at this point in the history
  3. Fix lint error

    Lunderberg committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    5154b4a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Use default expansion of TVM_BUILD_PATH

    Otherwise, `set -u` rightly errors out for it being undefined.
    Lunderberg committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    3e65c2c View commit details
    Browse the repository at this point in the history