New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TVMScript] ExprDoc #12048

Merged

junrushao merged 24 commits into apache:main from yelite:tunip-expr-doc

Jul 27, 2022

Contributor

yelite commented Jul 9, 2022 •

edited

Loading

This PR addes:

All ExprDoc subclasses
Their Python bindings
Support of ExprDoc in PythonDocPrinter
Unit tests for ExprDoc in PythonDocPrinter

Tracking issue: #11912

cc @junrushao1994 @gbonik


          Add expr doc

696bdaf

github-actions bot requested a review from junrushao

July 9, 2022 01:54

yelite mentioned this pull request

[Tracking Issue] TVMScript Unified Printer #11912

Closed

23 tasks

yelite added 13 commits

July 11, 2022 10:54


          Fix lint

07a5102


          Add ExprDoc support in PythonDocPrinter

4dee76c


          Fix typo

1580f48


          Simplify PrintJoinedDocs

fc5a7ef


          Fix lint

150f9e2


          Fix lint

1b78fde


          include array

9371b54


          Try to fix MSVC compile error

070c60a


          Simplify the implementation of OperatorToString

95f782d


          Remove unused header

7c81bf3


          Merge branch 'main' into tunip-expr-doc

33c7ef9


          Remove the usage of regex to unblock PR

216c98e


          Change include style

fb7a5e0

junrushao reviewed

View reviewed changes

include/tvm/script/printer/doc.h Outdated Show resolved Hide resolved

yelite added 2 commits

July 15, 2022 10:14


          Remove unnecessary template parameter

5e233ff


          Remove assert op and add if-then-else as op

c0a429e

Contributor Author

yelite commented Jul 15, 2022

I removed the Assert op as we are going to make assert a StmtDoc per dicussion with @junrushao1994. I also added an if-then-else special op


          Fix lint

99ffc18

This was referenced Jul 15, 2022

[Draft] StmtDoc yelite/tvm#8

Closed

[TVMScript] StmtDoc Definitions #12111

Merged

[TVMScript] StmtDoc Printing #12112

Merged

junrushao reviewed

View reviewed changes

include/tvm/script/printer/doc.h Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

include/tvm/script/printer/doc.h Show resolved Hide resolved

junrushao reviewed

View reviewed changes

python/tvm/script/printer/doc.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

python/tvm/script/printer/doc.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

python/tvm/script/printer/doc.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

python/tvm/script/printer/doc.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

python/tvm/script/printer/doc.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

python/tvm/script/printer/doc.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

python/tvm/script/printer/doc.py Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/script/printer/python_doc_printer.cc Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/script/printer/python_doc_printer.cc Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/script/printer/python_doc_printer.cc Outdated Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/script/printer/python_doc_printer.cc Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/script/printer/python_doc_printer.cc Show resolved Hide resolved

junrushao reviewed

View reviewed changes

src/script/printer/python_doc_printer.cc Show resolved Hide resolved

junrushao approved these changes

View reviewed changes

Member

junrushao left a comment

Thanks @yelite for the PR, especially carefully crafted tests! I left a few nitpicks but overall it looks pretty good!

yelite added 7 commits

July 16, 2022 21:56


          Be explicit on the enum value

a1ca5f4


          Add attr step to SliceDoc

12a9b3b


          Use accurate typing

19bfb25


          Change variable names and add more validation

7b53eb2


          Rename methods to be consistent between Python and C++

c3e3d3b


          Add missing doc

6fb9a1d


          Fix lint

f53aacc

junrushao merged commit 584b0f3 into apache:main

AndrewZhaoLuo mentioned this pull request

TVM v0.10.0.rc0 Release Candidate Notes #12979

Closed

xinetzone pushed a commit to daobook/tvm that referenced this pull request


          [TVMScript] ExprDoc (apache#12048)

e867e37

This PR addes:

- All ExprDoc subclasses
- Their Python bindings
- Support of ExprDoc in PythonDocPrinter
- Unit tests for ExprDoc in PythonDocPrinter

Tracking issue: apache#11912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet