-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TVMScript] Python Expression Precedence #12148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
yelite
force-pushed
the
tunip-expr-associativity
branch
2 times, most recently
from
July 25, 2022 18:24
d88bcc7
to
d2f87f8
Compare
junrushao
force-pushed
the
tunip-expr-associativity
branch
2 times, most recently
from
July 27, 2022 17:10
a3584aa
to
90b3a9c
Compare
yelite
force-pushed
the
tunip-expr-associativity
branch
from
July 28, 2022 16:23
90b3a9c
to
ca9079f
Compare
junrushao
reviewed
Aug 1, 2022
junrushao
reviewed
Aug 1, 2022
This PR: - Handle expression (operator) precedence during Python code printing (`(* 1 (+ 2 3))` prints as `1 * (2 + 3)`) - Addresses remaining feedback from previous PR apache#12112 - Reformats Python import with isort Tracking issue: apache#11912
junrushao
force-pushed
the
tunip-expr-associativity
branch
from
August 1, 2022 01:57
ca9079f
to
a3c7d73
Compare
junrushao
reviewed
Aug 1, 2022
junrushao
reviewed
Aug 1, 2022
junrushao
reviewed
Aug 1, 2022
junrushao
reviewed
Aug 1, 2022
junrushao
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR: - Handle expression (operator) precedence during Python code printing (`(* 1 (+ 2 3))` prints as `1 * (2 + 3)`) - Addresses remaining feedback from previous PR apache#12112 - Reformats Python import with isort Tracking issue: apache#11912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
(* 1 (+ 2 3))
prints as1 * (2 + 3)
)Tracking issue: #11912
cc @junrushao1994 @gbonik