-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hexagon][topi] add sliced max_pool2 #12169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconvey
force-pushed
the
sliced-maxpool
branch
4 times, most recently
from
July 26, 2022 21:40
3971bde
to
eb38e60
Compare
cconvey
force-pushed
the
sliced-maxpool
branch
3 times, most recently
from
August 4, 2022 08:19
1930996
to
5ab1ea1
Compare
cconvey
changed the title
WIP [hexagon][topi] add sliced max_pool2
[hexagon][topi] add sliced max_pool2
Aug 4, 2022
cconvey
commented
Aug 4, 2022
cconvey
commented
Aug 4, 2022
jverma-quic
reviewed
Aug 4, 2022
tests/python/contrib/test_hexagon/topi/test_max_pool2d_slice.py
Outdated
Show resolved
Hide resolved
cconvey
changed the title
[hexagon][topi] add sliced max_pool2
WIP [hexagon][topi] add sliced max_pool2
Aug 4, 2022
jverma-quic
reviewed
Aug 4, 2022
tests/python/contrib/test_hexagon/topi/test_max_pool2d_slice.py
Outdated
Show resolved
Hide resolved
cconvey
force-pushed
the
sliced-maxpool
branch
3 times, most recently
from
August 8, 2022 15:07
ea755a4
to
4d67376
Compare
cconvey
changed the title
WIP [hexagon][topi] add sliced max_pool2
[hexagon][topi] add sliced max_pool2
Aug 8, 2022
Add TOPI implementation of sliced max_pool2d, with basic scheduling.
@Lunderberg @csullivan : Any chance one of you could give this a review? |
jverma-quic
approved these changes
Aug 8, 2022
tmoreau89
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cconvey and @jverma-quic for the thorough review; LGTM
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Add TOPI implementation of sliced max_pool2d, with basic scheduling.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
Add TOPI implementation of sliced max_pool2d, with basic scheduling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TOPI implementation of sliced max_pool2d.
cc @mehrdadh