-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][tvmbot] Enable re-run for GitHub Actions #12295
Conversation
This reverts commit 51ad835.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @driazati! LGTM
except RuntimeError as e: | ||
# Ignore errors about jobs that are part of the same workflow to avoid | ||
# having to figure out which jobs are in which workflows ahead of time | ||
if "The workflow run containing this job is already running" in str(e): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this imply if one of the actions is still running from the last post, it will continue to run and the new instance of the same action will not start on a @tvm-bot rerun
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, a point for potential future improvement could also be to only restart jobs that failed on a rerun
. Since the commit hasn't changed the other actions that have passed likely do not need to be rerun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think (like 70% certain) this only comes up for double-requesting a re-run of the same job, so it should still restart everything from the previous set of jobs. Restarting only failed jobs is a good idea, I'll leave it for a follow up PR though
@tvm-bot merge |
Cannot merge, these CI jobs are not successful on 0d35fbd: |
This adds the right permissions so anyone associated with the repo can trigger a re-run (GitHub hasn't flagged all committers as repo `COLLABORATORS` for some reason so it's difficult to determine from a username who has commit rights) and makes it so `@tvm-bot rerun` also re-runs all the Actions on a PR.
This adds the right permissions so anyone associated with the repo can trigger a re-run (GitHub hasn't flagged all committers as repo
COLLABORATORS
for some reason so it's difficult to determine from a username who has commit rights) and makes it so@tvm-bot rerun
also re-runs all the Actions on a PR.cc @Mousius @areusch