Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][tvmbot] Enable re-run for GitHub Actions #12295

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Conversation

driazati
Copy link
Member

@driazati driazati commented Aug 3, 2022

This adds the right permissions so anyone associated with the repo can trigger a re-run (GitHub hasn't flagged all committers as repo COLLABORATORS for some reason so it's difficult to determine from a username who has commit rights) and makes it so @tvm-bot rerun also re-runs all the Actions on a PR.

cc @Mousius @areusch

@driazati driazati changed the title Fix up for merging [ci][tvmbot] Enable re-run for GitHub Actions Aug 3, 2022
@driazati driazati marked this pull request as ready for review August 3, 2022 21:17
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Built docs for commit 0d35fbd can be found here.

Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @driazati! LGTM

except RuntimeError as e:
# Ignore errors about jobs that are part of the same workflow to avoid
# having to figure out which jobs are in which workflows ahead of time
if "The workflow run containing this job is already running" in str(e):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this imply if one of the actions is still running from the last post, it will continue to run and the new instance of the same action will not start on a @tvm-bot rerun?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, a point for potential future improvement could also be to only restart jobs that failed on a rerun. Since the commit hasn't changed the other actions that have passed likely do not need to be rerun.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (like 70% certain) this only comes up for double-requesting a re-run of the same job, so it should still restart everything from the previous set of jobs. Restarting only failed jobs is a good idea, I'll leave it for a follow up PR though

@driazati
Copy link
Member Author

driazati commented Aug 4, 2022

@tvm-bot merge

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Cannot merge, these CI jobs are not successful on 0d35fbd:

@driazati driazati merged commit 78b3fc2 into apache:main Aug 4, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This adds the right permissions so anyone associated with the repo can trigger a re-run (GitHub hasn't flagged all committers as repo `COLLABORATORS` for some reason so it's difficult to determine from a username who has commit rights) and makes it so `@tvm-bot rerun` also re-runs all the Actions on a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants