[CMSIS-NN] Re-use CPU Target Parser #12320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
force-pushed
the
target-parser-cmsis-nn
branch
from
c474c30
to
bfed2a9
Compare
Previously `CMSISNNFlags` was derived using logic specific to the external code generator, this converts the external code generator options into a `Target`.
Mousius
force-pushed
the
target-parser-cmsis-nn
branch
from
bfed2a9
to
3d4c059
Compare
areusch
approved these changes
Aug 18, 2022
| @@ -31,10 +34,11 @@ tvm::transform::Pass RelayToTIR(); | |||
| runtime::Module TIRToRuntime(IRModule mod, Target target); | |||
|
|
|||
| TVM_REGISTER_TARGET_KIND("cmsis-nn", kDLCPU) | |||
| .add_attr_option<Array<String>>("mattr") | |||
| .add_attr_option<String>("mcpu") | |||
There was a problem hiding this comment.
just musing, i'm sensing we'll shortly want a way to express this as "whatever target_host did"
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Previously `CMSISNNFlags` was derived using logic specific to the external code generator, this converts the external code generator options into a `Target`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
CMSISNNFlagswas derived using logic specific to the external code generator, this converts the external code generator options into aTarget.cc @areusch